content/common/mojo/mojo_shell_connection_impl.cc - Issue 1814223002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/mojo/mojo_shell_connection_impl.cc

Issue 1814223002: Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.h ('k') | mash/browser_driver/browser_driver_application_delegate.h » ('j') | mojo/shell/public/cpp/lib/application_runner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/mojo/mojo_shell_connection_impl.cc

diff --git a/content/common/mojo/mojo_shell_connection_impl.cc b/content/common/mojo/mojo_shell_connection_impl.cc

index 8321673424b1d9ad1ce500d10701741d17b220bf..58f2d135588ee74860045862e68e41603057d90d 100644

--- a/content/common/mojo/mojo_shell_connection_impl.cc

+++ b/content/common/mojo/mojo_shell_connection_impl.cc

@@ -98,10 +98,6 @@ bool MojoShellConnectionImpl::AcceptConnection(mojo::Connection* connection) {

return found;

}

-void MojoShellConnectionImpl::ShellConnectionLost() {

- LOG(ERROR) << "Shell connection lost.";

mojo::Connector* MojoShellConnectionImpl::GetConnector() {

DCHECK(shell_connection_);

return shell_connection_->connector();