Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1814213002: Properly handle the Module SBDatabase when it's corrupted (Closed)

Created:
4 years, 9 months ago by proberge
Modified:
4 years, 9 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Properly handle the Module SBDatabase when it's corrupted NOTRY=true NOPRESUBMIT=true BUG=595444 Review URL: https://codereview.chromium.org/1807253002 Cr-Commit-Position: refs/heads/master@{#381809} (cherry picked from commit 78dad59bea7ba92dfa77efd3d79fed9d6baad85b)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/safe_browsing/safe_browsing_database.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 2 chunks +8 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
proberge
Still need to get Merge-Request-50-Approved on the bug.
4 years, 9 months ago (2016-03-18 13:46:43 UTC) #3
Nathan Parker
lgtm
4 years, 9 months ago (2016-03-18 21:24:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814213002/1
4 years, 9 months ago (2016-03-21 13:45:59 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 9 months ago (2016-03-21 13:46:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814213002/1
4 years, 9 months ago (2016-03-21 13:47:27 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 13:49:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698