Better filling on suggestion of password fields in Password Manager.

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <tuple>
 
 #include "base/macros.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/renderer/autofill/password_generation_test_utils.h"
@@ skipping 1256 matching lines @@
   // clicking on the username element. This should also produce a message with
   // all the usernames.
   SimulateUsernameChange("baz");
   render_thread_->sink().ClearMessages();
   static_cast<PageClickListener*>(autofill_agent_)
       ->FormControlElementClicked(username_element_, true);
   CheckSuggestions("baz", true);
   ClearUsernameAndPasswordFields();
 }
 
-// Tests that there are no autosuggestions from the password manager when the
-// user clicks on the password field and the username field is editable when
-// FillOnAccountSelect is enabled.
+// Tests that there is an autosuggestion from the password manager when the
+// user clicks on the password field when FillOnAccountSelect is enabled.
 TEST_F(PasswordAutofillAgentTest,
        FillOnAccountSelectOnlyNoCredentialsOnPasswordClick) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       autofill::switches::kEnableFillOnAccountSelect);
 
   // Simulate the browser sending back the login info.
   SimulateOnFillPasswordForm(fill_data_);
 
   // Clear the text fields to start fresh.
   ClearUsernameAndPasswordFields();
 
   // Call SimulateElementClick() to produce a user gesture on the page so
   // autofill will actually fill.
   SimulateElementClick(kUsernameName);
 
   // Simulate a user clicking on the password element. This should produce no
   // message.
   render_thread_->sink().ClearMessages();
   static_cast<PageClickListener*>(autofill_agent_)
       ->FormControlElementClicked(password_element_, false);
-  EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
+  EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
       AutofillHostMsg_ShowPasswordSuggestions::ID));
 }
 
 // Tests the autosuggestions that are given when a password element is clicked,
 // the username element is not editable, and FillOnAccountSelect is enabled.
 // Specifically, tests when the user clicks on the password element after page
 // load, and the corresponding username element is readonly (and thus
 // uneditable), that the credentials for the already-filled username are
 // suggested.
 TEST_F(PasswordAutofillAgentTest,
@@ skipping 10 matching lines @@
   // Simulate the page loading with a prefilled username element that is
   // uneditable.
   username_element_.setValue("alicia");
   SetElementReadOnly(username_element_, true);
 
   // Call SimulateElementClick() to produce a user gesture on the page so
   // autofill will actually fill.
   SimulateElementClick(kUsernameName);
 
   // Simulate a user clicking on the password element. This should produce a
-  // message with "alicia" suggested as the credential.
+  // dropdown with suggestion of all available usernames and so username
+  // filter will be the empty string.
   render_thread_->sink().ClearMessages();
   static_cast<PageClickListener*>(autofill_agent_)
       ->FormControlElementClicked(password_element_, false);
-  CheckSuggestions("alicia", false);
+  CheckSuggestions("", false);
 }
 
-// Tests that there are no autosuggestions from the password manager when the
-// user clicks on the password field (not the username field).
+// Tests that there is an autosuggestion from the password manager when the
+// user clicks on the password field.
 TEST_F(PasswordAutofillAgentTest, NoCredentialsOnPasswordClick) {
   // Simulate the browser sending back the login info.
   SimulateOnFillPasswordForm(fill_data_);
 
   // Clear the text fields to start fresh.
   ClearUsernameAndPasswordFields();
 
   // Call SimulateElementClick() to produce a user gesture on the page so
   // autofill will actually fill.
   SimulateElementClick(kUsernameName);
 
   // Simulate a user clicking on the password element. This should produce no
   // message.
   render_thread_->sink().ClearMessages();
   static_cast<PageClickListener*>(autofill_agent_)
       ->FormControlElementClicked(password_element_, false);
-  EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
+  EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
       AutofillHostMsg_ShowPasswordSuggestions::ID));
 }
 
 // The user types in a username and a password, but then just before sending
 // the form off, a script clears them. This test checks that
 // PasswordAutofillAgent can still remember the username and the password
 // typed by the user.
 TEST_F(PasswordAutofillAgentTest,
        RememberLastNonEmptyUsernameAndPasswordOnSubmit_ScriptCleared) {
   SimulateUsernameChange("temp");
@@ skipping 605 matching lines @@
   fill_data_.is_possible_change_password_form = true;
   SimulateOnFillPasswordForm(fill_data_);
   // Simulate a user clicking on the password element. This should produce a
   // message.
   render_thread_->sink().ClearMessages();
   static_cast<PageClickListener*>(autofill_agent_)
       ->FormControlElementClicked(password_element_, true);
   CheckSuggestions("", false);
 }
 
-// Tests that there are no autosuggestions from the password manager when the
-// user clicks on the password field of change password form after the user
-// typed in the username field.
-TEST_F(PasswordAutofillAgentTest,
-       NoSuggestionsOnPasswordFieldOfChangePasswordFormAfterUsernameTyping) {
-  LoadHTML(kPasswordChangeFormHTML);
-  UpdateOriginForHTML(kPasswordChangeFormHTML);
-  UpdateUsernameAndPasswordElements();
-
-  ClearUsernameAndPasswordFields();
-  fill_data_.wait_for_username = true;
-  fill_data_.is_possible_change_password_form = true;
-  SimulateOnFillPasswordForm(fill_data_);
-
-  // Clear the text fields to start fresh.
-  SimulateUsernameChange("temp");
-
-  // Simulate a user clicking on the password element. This should produce no
-  // message.
-  render_thread_->sink().ClearMessages();
-  static_cast<PageClickListener*>(autofill_agent_)
-      ->FormControlElementClicked(password_element_, false);
-  EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
-      AutofillHostMsg_ShowPasswordSuggestions::ID));
-}
-
 // Tests that NOT_PASSWORD field predictions are followed so that no password
 // form is submitted.
 TEST_F(PasswordAutofillAgentTest, IgnoreNotPasswordFields) {
   LoadHTML(kCreditCardFormHTML);
   blink::WebInputElement credit_card_owner_element =
       GetInputElementByID(kCreditCardOwnerName);
   blink::WebInputElement credit_card_number_element =
       GetInputElementByID(kCreditCardNumberName);
   blink::WebInputElement credit_card_verification_element =
       GetInputElementByID(kCreditCardVerificationName);
@@ skipping 302 matching lines @@
   SimulateUsernameChange("Alice");
 
   static_cast<content::RenderFrameObserver*>(password_autofill_agent_)
       ->WillSendSubmitEvent(username_element_.form());
   static_cast<content::RenderFrameObserver*>(password_autofill_agent_)
       ->WillSubmitForm(username_element_.form());
 
   ExpectFormSubmittedWithUsernameAndPasswords("Alice", "mypassword", "");
 }
 
+// Tests that a suggestion dropdown is shown on a password field even if a
+// username field is present.
+TEST_F(PasswordAutofillAgentTest, SuggestPasswordFieldSignInForm) {
+  // Simulate the browser sending back the login info.
+  SimulateOnFillPasswordForm(fill_data_);
+
+  // Call SimulateElementClick() to produce a user gesture on the page so
+  // autofill will actually fill.
+  SimulateElementClick(kUsernameName);
+
+  // Simulate a user clicking on the password element. This should produce a
+  // dropdown with suggestion of all available usernames.
+  render_thread_->sink().ClearMessages();
+  static_cast<PageClickListener*>(autofill_agent_)
+      ->FormControlElementClicked(password_element_, false);
+  CheckSuggestions("", false);
+}
+
+// Tests that a suggestion dropdown is shown on each password field. But when a
+// user chose one of the fields to autofill, a suggestion dropdown will be shown
+// only on this field.
+TEST_F(PasswordAutofillAgentTest, SuggestMultiplePasswordFields) {
+  LoadHTML(kPasswordChangeFormHTML);
+  UpdateOriginForHTML(kPasswordChangeFormHTML);
+  UpdateUsernameAndPasswordElements();
+
+  // Simulate the browser sending back the login info.
+  SimulateOnFillPasswordForm(fill_data_);
+
+  // Call SimulateElementClick() to produce a user gesture on the page so
+  // autofill will actually fill.
+  SimulateElementClick(kUsernameName);
+
+  // Simulate a user clicking on the password elements. This should produce
+  // dropdowns with suggestion of all available usernames.
+  render_thread_->sink().ClearMessages();
+  SimulateElementClick("password");
+  CheckSuggestions("", false);
+
+  SimulateElementClick("newpassword");
+  CheckSuggestions("", false);
+
+  SimulateElementClick("confirmpassword");
+  CheckSuggestions("", false);
+
+  // The user chooses to autofill the current password field.
+  EXPECT_TRUE(password_autofill_agent_->FillSuggestion(
+      password_element_, kAliceUsername, kAlicePassword));
+
+  // Simulate a user clicking on not autofilled password fields. This should
+  // produce
+  // no suggestion dropdowns.
+  render_thread_->sink().ClearMessages();
+  SimulateElementClick("newpassword");
+  SimulateElementClick("confirmpassword");
+  EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(
+      AutofillHostMsg_ShowPasswordSuggestions::ID));
+
+  // But when the user clicks on the autofilled password field again it should
+  // still produce a suggestion dropdown.
+  SimulateElementClick("password");
+  CheckSuggestions("", false);
+}
+
 }  // namespace autofill