Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2861)

Unified Diff: components/browsing_data_ui/history_notice_utils.cc

Issue 1814173002: Only show the notice about other forms of browsing history if sync is active (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_component
Patch Set: Forgotten negation. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browsing_data_ui/history_notice_utils.cc
diff --git a/components/browsing_data_ui/history_notice_utils.cc b/components/browsing_data_ui/history_notice_utils.cc
index a467c669836f0364030068de7c2c8c3af6e8642a..7a6fa132e72adfc1a6ce8f16f677a986d5ce9a28 100644
--- a/components/browsing_data_ui/history_notice_utils.cc
+++ b/components/browsing_data_ui/history_notice_utils.cc
@@ -13,7 +13,8 @@ bool ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
const ProfileSyncService* sync_service,
const history::WebHistoryService* history_service) {
return sync_service &&
- sync_service->IsUsingSecondaryPassphrase() &&
+ sync_service->IsSyncActive() &&
+ !sync_service->IsUsingSecondaryPassphrase() &&
history_service &&
history_service->HasOtherFormsOfBrowsingHistory();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698