Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1814143002: Files app: You have to use "contentThumbnailUrl" for artwork, and fix nits. (Closed)

Created:
4 years, 9 months ago by ryoh
Modified:
4 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: You have to use "contentThumbnailUrl" for artwork, and fix nits. BUG=595966 Committed: https://crrev.com/b0ff1b57ae720ec86d8f5a2805837ead0e99a239 Cr-Commit-Position: refs/heads/master@{#381903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/single_file_details.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ryoh
This patch fixes the careless mistake. Could you take a look?
4 years, 9 months ago (2016-03-18 05:14:32 UTC) #2
fukino
lgtm
4 years, 9 months ago (2016-03-18 05:21:43 UTC) #3
ryoh
On 2016/03/18 05:21:43, fukino wrote: > lgtm thanks!
4 years, 9 months ago (2016-03-18 05:22:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814143002/1
4 years, 9 months ago (2016-03-18 05:22:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 06:47:10 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 06:49:12 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b0ff1b57ae720ec86d8f5a2805837ead0e99a239
Cr-Commit-Position: refs/heads/master@{#381903}

Powered by Google App Engine
This is Rietveld 408576698