Replace misc. network stub flags with more flexible ones

chromeos/network/network_device_handler_unittest.cc

Index: chromeos/network/network_device_handler_unittest.cc
diff --git a/chromeos/network/network_device_handler_unittest.cc b/chromeos/network/network_device_handler_unittest.cc
index fb1fc299577cb6ce86e93b0291f7e6cb0b32d715..d19b48a9bd3235621134195b49c9848e7868efe0 100644
--- a/chromeos/network/network_device_handler_unittest.cc
+++ b/chromeos/network/network_device_handler_unittest.cc
@@ -33,11 +33,13 @@ class NetworkDeviceHandlerTest : public testing::Test {
   virtual void SetUp() OVERRIDE {
     FakeDBusThreadManager* dbus_manager = new FakeDBusThreadManager;
     dbus_manager->SetFakeShillClients();
+    DBusThreadManager::InitializeForTesting(dbus_manager);

[pneubeck (no reviews), 2014/02/28 09:37:59]

Do you change this order just to get rid of the devices that
FakeShillManagerClient::SetupDefaultEnvironment setup up?
Please call SetupDefaultEnvironment explicitly and don't change the order here.

[stevenjb, 2014/02/28 17:43:06]

I see. This confused me, the behavior changed form how I remembered it, I
thought this was incorrect. I forgot that InitializeForTesting doesn't actually
create any fake implementations. I'll change this back.

 
+    // Set a new FakeShillDeviceClient (with no devices) after initialize
+    // dbus_manager.
     fake_device_client_ = new FakeShillDeviceClient;
     dbus_manager->SetShillDeviceClient(
         scoped_ptr<ShillDeviceClient>(fake_device_client_));
-    DBusThreadManager::InitializeForTesting(dbus_manager);
 
     success_callback_ = base::Bind(&NetworkDeviceHandlerTest::SuccessCallback,
                                    base::Unretained(this));