chrome/browser/extensions/api/networking_private/networking_private_apitest.cc - Issue 181413006: Replace misc. network stub flags with more flexible ones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

Issue 181413006: Replace misc. network stub flags with more flexible ones (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Elim. shill_stub_helper and move functions to clients. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/net/network_portal_detector_impl.cc ('K') | « chrome/browser/chromeos/net/network_portal_detector_impl.cc ('k') | chromeos/chromeos.gyp » ('j') | chromeos/dbus/dbus_thread_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

index 19441df3225f3611cb33d62da136d84454e0fe19..ca58c84cfc5f354b08c85807a2a61bc61dc98907 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

@@ -20,7 +20,6 @@

#include "chromeos/dbus/shill_manager_client.h"

#include "chromeos/dbus/shill_profile_client.h"

#include "chromeos/dbus/shill_service_client.h"

-#include "chromeos/dbus/shill_stub_helper.h"

#include "chromeos/network/onc/onc_utils.h"

#include "components/onc/onc_constants.h"

#include "components/policy/core/browser/browser_policy_connector.h"

@@ -171,8 +170,8 @@ class ExtensionNetworkingPrivateApiTest :

service_test->SetServiceProperty(

"stub_ethernet",

shill::kProfileProperty,

- base::StringValue(chromeos::shill_stub_helper::kSharedProfilePath));

- profile_test->AddService(chromeos::shill_stub_helper::kSharedProfilePath,

+ base::StringValue(ShillProfileClient::GetSharedProfilePath()));

+ profile_test->AddService(ShillProfileClient::GetSharedProfilePath(),

"stub_ethernet");

service_test->AddService("stub_wifi1", "wifi1",