chrome/browser/chromeos/login/user_image_loader.cc - Issue 181413006: Replace misc. network stub flags with more flexible ones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/user_image_loader.cc

Issue 181413006: Replace misc. network stub flags with more flexible ones (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Elim. shill_stub_helper and move functions to clients. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/user_image_loader.cc

diff --git a/chrome/browser/chromeos/login/user_image_loader.cc b/chrome/browser/chromeos/login/user_image_loader.cc

index bbb7c6b31bfacaf7a1909b2c5b2a285cc528eaf6..6ecb0ed6a90bea250f38ac03d91f2654ea8c632e 100644

--- a/chrome/browser/chromeos/login/user_image_loader.cc

+++ b/chrome/browser/chromeos/login/user_image_loader.cc

@@ -68,7 +68,7 @@ void UserImageLoader::ReadAndDecodeImage(const std::string& filepath,

scoped_ptr<std::string> data(new std::string);

const bool success =

base::ReadFileToString(base::FilePath(filepath), data.get());

- DCHECK(success);

+ if (!success) return;

pneubeck (no reviews) 2014/02/28 09:37:59 please don't include this unrelated(?) functional

stevenjb 2014/02/28 17:43:06 Accidental.

DecodeImage(data.Pass(), image_info);

}