Replace misc. network stub flags with more flexible ones

chromeos/dbus/dbus_thread_manager.h

Index: chromeos/dbus/dbus_thread_manager.h
diff --git a/chromeos/dbus/dbus_thread_manager.h b/chromeos/dbus/dbus_thread_manager.h
index c36ddc3dfe87cc28470a83afd4b3cd2561cb852f..61d3978548980a89a5fbc6a767bb6e355800f8a7 100644
--- a/chromeos/dbus/dbus_thread_manager.h
+++ b/chromeos/dbus/dbus_thread_manager.h
@@ -150,6 +150,12 @@ class CHROMEOS_EXPORT DBusThreadManager {
   virtual SystemClockClient* GetSystemClockClient() = 0;
   virtual UpdateEngineClient* GetUpdateEngineClient() = 0;
 
+  // These methods can be overridden by Fake or Test implementations to provide
+  // initial behavior overrides (e.g. based on command line flags).
+  virtual int GetPowerCycleDelay() const;
+  virtual int GetShillInteractiveDelay() const;

[pneubeck (no reviews), 2014/02/27 09:04:37]

not sure about GetPowerCycleDelay,
but the GetShill* should really not be part of the production code.
please move them to the FakeDBusThreadManager.

You could pass the FakeDBusThreadManager to the fake ShillClients' constructor
or alternatively pass only some configuration (which would cleanup the
dependencies).
See my later comments...

[stevenjb, 2014/02/28 02:44:06]

I'm not super thrilled about passing FakeDBusThreadManager to every ShillClient
constructor. I think I would rather just move this to the appropriate clients
instead (ShillManagerClient for Shill).
 

+  virtual std::string GetShillInitialState(const std::string& type) const;
+
   virtual ~DBusThreadManager();
 
  protected: