Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chromeos/network/network_state_handler.cc

Issue 181413006: Replace misc. network stub flags with more flexible ones (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/sms_client.cc ('k') | chromeos/network/network_state_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_state_handler.cc
diff --git a/chromeos/network/network_state_handler.cc b/chromeos/network/network_state_handler.cc
index c09127146fc830b67bbdf323e555112ed8d3213f..972b6759ea6e205e4fdb7fd5dc1852b376806878 100644
--- a/chromeos/network/network_state_handler.cc
+++ b/chromeos/network/network_state_handler.cc
@@ -191,8 +191,10 @@ const FavoriteState* NetworkStateHandler::DefaultFavoriteNetwork() const {
return NULL;
const FavoriteState* default_favorite =
GetFavoriteState(default_network->path());
- DCHECK(default_favorite);
- DCHECK(default_favorite->update_received());
+ DCHECK(default_network->type() != shill::kTypeWifi ||
+ default_favorite) << "No favorite for: " << default_network->path();
+ DCHECK(!default_favorite || default_favorite->update_received())
+ << "No update received for: " << default_network->path();
return default_favorite;
}
« no previous file with comments | « chromeos/dbus/sms_client.cc ('k') | chromeos/network/network_state_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698