Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: chromeos/dbus/fake_shill_manager_client.h

Issue 181413006: Replace misc. network stub flags with more flexible ones (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/fake_shill_manager_client.h
diff --git a/chromeos/dbus/fake_shill_manager_client.h b/chromeos/dbus/fake_shill_manager_client.h
index 65f449eb55262aa1e60afb0bd5b5b2ac919e6fb5..491a7587fb23310d1cabc8db7c360ddcdc860270 100644
--- a/chromeos/dbus/fake_shill_manager_client.h
+++ b/chromeos/dbus/fake_shill_manager_client.h
@@ -17,8 +17,8 @@ namespace chromeos {
// A fake implementation of ShillManagerClient. This works in close coordination
// with FakeShillServiceClient. FakeShillDeviceClient, and
// FakeShillProfileClient, and is not intended to be used independently.
-class CHROMEOS_EXPORT FakeShillManagerClient :
- public ShillManagerClient,
+class CHROMEOS_EXPORT FakeShillManagerClient
+ : public ShillManagerClient,
public ShillManagerClient::TestInterface {
public:
FakeShillManagerClient();
@@ -97,14 +97,15 @@ class CHROMEOS_EXPORT FakeShillManagerClient :
virtual void RemoveManagerService(const std::string& service_path) OVERRIDE;
virtual void ClearManagerServices() OVERRIDE;
virtual void SortManagerServices() OVERRIDE;
+ virtual void SetupDefaultEnvironment() OVERRIDE;
+ virtual int GetInteractiveDelay() const OVERRIDE;
private:
void AddServiceToWatchList(const std::string& service_path);
void SetDefaultProperties();
void PassStubProperties(const DictionaryValueCallback& callback) const;
void PassStubGeoNetworks(const DictionaryValueCallback& callback) const;
- void CallNotifyObserversPropertyChanged(const std::string& property,
- int delay_ms);
+ void CallNotifyObserversPropertyChanged(const std::string& property);
void NotifyObserversPropertyChanged(const std::string& property);
base::ListValue* GetListProperty(const std::string& property);
bool TechnologyEnabled(const std::string& type) const;
@@ -115,11 +116,28 @@ class CHROMEOS_EXPORT FakeShillManagerClient :
void ScanCompleted(const std::string& device_path,
const base::Closure& callback);
+ // Parses the command line for Shill stub switches and sets initial states.
+ // Uses comma-separated name-value pairs (see dbus_command_line_helper):
+ // interactive={delay} - sets delay in seconds for interactive UI
+ // {wifi,cellular,etc}={on,off,disabled,none} - sets initial state for type
+ void ParseCommandLineSwitch();
+ bool ParseOption(const std::string& arg0, const std::string& arg1);
+ bool SetInitialNetworkState(std::string type_arg, std::string state_arg);
+ std::string GetInitialStateForType(const std::string& type,
+ bool* enabled);
+
// Dictionary of property name -> property value
base::DictionaryValue stub_properties_;
+
// Dictionary of technology -> list of property dictionaries
base::DictionaryValue stub_geo_networks_;
+ // Seconds to delay interactive actions
+ int interactive_delay_;
+
+ // Initial state for fake services.
+ std::map<std::string, std::string> shill_initial_state_map_;
+
ObserverList<ShillPropertyChangedObserver> observer_list_;
// Note: This should remain the last member so it'll be destroyed and

Powered by Google App Engine
This is Rietveld 408576698