Replace misc. network stub flags with more flexible ones

chromeos/dbus/fake_dbus_thread_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_FAKE_DBUS_THREAD_MANAGER_H_
 #define CHROMEOS_DBUS_FAKE_DBUS_THREAD_MANAGER_H_
 
+#include <map>
 #include <string>
 
 #include "base/logging.h"
 #include "base/observer_list.h"
 #include "chromeos/chromeos_export.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 
 namespace dbus {
 class Bus;
 class ObjectPath;
@@ skipping 79 matching lines @@
   virtual NfcRecordClient* GetNfcRecordClient() OVERRIDE;
   virtual NfcTagClient* GetNfcTagClient() OVERRIDE;
   virtual PermissionBrokerClient* GetPermissionBrokerClient() OVERRIDE;
   virtual PowerManagerClient* GetPowerManagerClient() OVERRIDE;
   virtual PowerPolicyController* GetPowerPolicyController() OVERRIDE;
   virtual SessionManagerClient* GetSessionManagerClient() OVERRIDE;
   virtual SMSClient* GetSMSClient() OVERRIDE;
   virtual SystemClockClient* GetSystemClockClient() OVERRIDE;
   virtual UpdateEngineClient* GetUpdateEngineClient() OVERRIDE;
 
+  virtual int GetPowerCycleDelay() const OVERRIDE;
+  virtual int GetShillInteractiveDelay() const OVERRIDE;
+  virtual std::string GetShillInitialState(
+      const std::string& type) const OVERRIDE;
+
  private:
+  // Parses the command line for Power stub switches and sets initial states.
+  void ParsePowerCommandLineSwitch();
+
+  // Parses the command line for Shill stub switches and sets initial states.
+  void ParseShillCommandLineSwitch();
+
+  // Parses options of format foo=bar, setting *arg0=foo, *arg1=bar (optional).
+  // Returns true if parsed successfully, false otherwise.
+  bool GetOptionArgs(const std::string& option,
+                     std::string* arg0,
+                     std::string* arg1);
+
+  // Sets the initial state for Shill networks matching |type_arg|.
+  void SetShillInitialNetworkState(std::string type_arg, std::string state_arg);
+
   // Note: Keep this before other members so they can call AddObserver() in
   // their c'tors.
   ObserverList<DBusThreadManagerObserver> observers_;
 
   scoped_ptr<BluetoothAdapterClient> bluetooth_adapter_client_;
   scoped_ptr<BluetoothAgentManagerClient> bluetooth_agent_manager_client_;
   scoped_ptr<BluetoothDeviceClient> bluetooth_device_client_;
   scoped_ptr<BluetoothInputClient> bluetooth_input_client_;
   scoped_ptr<BluetoothProfileManagerClient> bluetooth_profile_manager_client_;
   scoped_ptr<CrasAudioClient> cras_audio_client_;
@@ skipping 16 matching lines @@
   scoped_ptr<NfcTagClient> nfc_tag_client_;
   scoped_ptr<PermissionBrokerClient> permission_broker_client_;
   scoped_ptr<SystemClockClient> system_clock_client_;
   scoped_ptr<PowerManagerClient> power_manager_client_;
   scoped_ptr<SessionManagerClient> session_manager_client_;
   scoped_ptr<SMSClient> sms_client_;
   scoped_ptr<UpdateEngineClient> update_engine_client_;
 
   scoped_ptr<PowerPolicyController> power_policy_controller_;
 
+  int power_cycle_delay_;  // Seconds over which to cycle power state
+  int shill_interactive_delay_;  // Seconds to delay interactive actions

[pneubeck (no reviews), 2014/02/27 09:04:37]

you could put these two shill_* members into a ShillTestConfiguration struct and
pass that directly to the fake Shill*Clients.
This config could be optional for the construction of the clients.

[stevenjb, 2014/02/28 02:44:06]

Moved implementation to clients.

+  std::map<std::string, std::string> shill_initial_state_map_;
+
   DISALLOW_COPY_AND_ASSIGN(FakeDBusThreadManager);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_FAKE_DBUS_THREAD_MANAGER_H_