Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2556)

Side by Side Diff: chrome/browser/autofill/autofill_interactive_uitest.cc

Issue 1814103003: Disable OnSelectOptionFromDatalist on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_util.h" 8 #include "base/files/file_util.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 649
650 // Invoke and accept the Autofill popup and verify the field was filled. 650 // Invoke and accept the Autofill popup and verify the field was filled.
651 SendKeyToPageAndWait(ui::VKEY_M); 651 SendKeyToPageAndWait(ui::VKEY_M);
652 SendKeyToPopupAndWait(ui::VKEY_DOWN); 652 SendKeyToPopupAndWait(ui::VKEY_DOWN);
653 SendKeyToPopupAndWait(ui::VKEY_RETURN); 653 SendKeyToPopupAndWait(ui::VKEY_RETURN);
654 ExpectFieldValue("firstname", "Milton"); 654 ExpectFieldValue("firstname", "Milton");
655 } 655 }
656 656
657 // Test that an input field is not rendered with the yellow autofilled 657 // Test that an input field is not rendered with the yellow autofilled
658 // background color when choosing an option from the datalist suggestion list. 658 // background color when choosing an option from the datalist suggestion list.
659 #if defined(OS_MACOSX) 659 #if defined(OS_MACOSX) || defined(OS_CHROMEOS)
660 // Flakily triggers and assert on Mac. 660 // Flakily triggers and assert on Mac; flakily gets empty string instead
661 // http://crbug.com/419868 661 // of "Adam" on ChromeOS.
662 // http://crbug.com/419868, http://crbug.com/595385.
662 #define MAYBE_OnSelectOptionFromDatalist DISABLED_OnSelectOptionFromDatalist 663 #define MAYBE_OnSelectOptionFromDatalist DISABLED_OnSelectOptionFromDatalist
663 #else 664 #else
664 #define MAYBE_OnSelectOptionFromDatalist OnSelectOptionFromDatalist 665 #define MAYBE_OnSelectOptionFromDatalist OnSelectOptionFromDatalist
665 #endif 666 #endif
666 IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, 667 IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest,
667 MAYBE_OnSelectOptionFromDatalist) { 668 MAYBE_OnSelectOptionFromDatalist) {
668 // Load the test page. 669 // Load the test page.
669 ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL( 670 ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(
670 browser(), 671 browser(),
671 GURL(std::string(kDataURIPrefix) + 672 GURL(std::string(kDataURIPrefix) +
(...skipping 831 matching lines...) Expand 10 before | Expand all | Expand 10 after
1503 ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(), 1504 ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(browser(),
1504 GURL(std::string(kDataURIPrefix) + kTestPasswordFormString))); 1505 GURL(std::string(kDataURIPrefix) + kTestPasswordFormString)));
1505 ASSERT_TRUE(content::ExecuteScript( 1506 ASSERT_TRUE(content::ExecuteScript(
1506 GetRenderViewHost(), 1507 GetRenderViewHost(),
1507 "document.getElementById('user').value = 'user';")); 1508 "document.getElementById('user').value = 'user';"));
1508 FocusFieldByName("password"); 1509 FocusFieldByName("password");
1509 PasteStringAndWait("foobar"); 1510 PasteStringAndWait("foobar");
1510 } 1511 }
1511 1512
1512 } // namespace autofill 1513 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698