runtime/vm/intrinsifier_mips.cc - Issue 18141002: Fixes a bug in the mips Random_nextState intrinsic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_mips.cc

Issue 18141002: Fixes a bug in the mips Random_nextState intrinsic. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_mips.cc

===================================================================

--- runtime/vm/intrinsifier_mips.cc (revision 24548)

+++ runtime/vm/intrinsifier_mips.cc (working copy)

@@ -1459,11 +1459,10 @@

__ LoadImmediate(T0, a_int32_value);

__ lw(T2, addr_0);

__ lw(T3, addr_1);

- __ sra(T6, T3, 31); // Sign extend T3 into T6.

__ mtlo(T3);

- __ mthi(T6); // HI:LO <- T6:T3

+ __ mthi(ZR); // HI:LO <- ZR:T3 Zero extend T3 into HI.

// 64-bit multiply and accumulate into T6:T3.

- __ madd(T0, T2); // HI:LO <- HI:LO + T0 * T2.

+ __ maddu(T0, T2); // HI:LO <- HI:LO + T0 * T2.

__ mflo(T3);

__ mfhi(T6);

__ sw(T3, addr_0);

« no previous file with comments | « no previous file | runtime/vm/simulator_mips.cc » ('j') | no next file with comments »