Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1814043002: Revert of Update DevTools Tracing.Start to accept trace config as a parameter (Closed)

Created:
4 years, 9 months ago by fgorski
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, blink-reviews, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, mkwst+moarreviews-renderer_chromium.org, dglazkov+blink, darin-cc_chromium.org, devtools-reviews_chromium.org, tracing+reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, blink-reviews-api_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org, rnephew (Reviews Here), fmeawad, petrcermak, lpy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update DevTools Tracing.Start to accept trace config as a parameter (patchset #10 id:180001 of https://codereview.chromium.org/1765153002/ ) Reason for revert: TraceConfigTest.TraceConfigFromDict fialed https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/21289/steps/base_unittests/logs/stdio https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/21289 Original issue's description: > Update DevTools Tracing.Start to accept trace config as > a parameter > > This CL updates Tracing.Start to accept trace config as > a parameter when starting tracing. It is backward compatible > with the old way. > > Design doc: https://goo.gl/GxQ23k > BUG=579358 > > Committed: https://crrev.com/c0e3792f832fc454324dbe35d01079b124b072cd > Cr-Commit-Position: refs/heads/master@{#381783} TBR=caseq@chromium.org,primiano@chromium.org,nednguyen@google.com,petrcermak@chromium.org,simonhatch@chromium.org,pfeldman@chromium.org,zhenw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=579358 Committed: https://crrev.com/46d2c0ed24c95bd4cc16e51c88bd9f322795e369 Cr-Commit-Position: refs/heads/master@{#381794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -309 lines) Patch
M base/trace_event/trace_config.h View 2 chunks +1 line, -8 lines 0 comments Download
M base/trace_event/trace_config.cc View 3 chunks +19 lines, -30 lines 0 comments Download
M base/trace_event/trace_config_unittest.cc View 3 chunks +0 lines, -63 lines 0 comments Download
M components/tracing/trace_config_file.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/tracing_handler.h View 4 chunks +1 line, -9 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 4 chunks +8 lines, -78 lines 0 comments Download
D content/browser/devtools/protocol/tracing_handler_unittest.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 chunk +3 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fgorski
Created Revert of Update DevTools Tracing.Start to accept trace config as a parameter
4 years, 9 months ago (2016-03-17 20:52:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814043002/1
4 years, 9 months ago (2016-03-17 20:53:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 20:54:00 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 20:55:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46d2c0ed24c95bd4cc16e51c88bd9f322795e369
Cr-Commit-Position: refs/heads/master@{#381794}

Powered by Google App Engine
This is Rietveld 408576698