[MD settings] change side nav icons

[MD settings] change side nav icons

This CL changes several side nav icons and moves
the OnStartup section under the DefaultBrowser
section.

TBR=dbeam@chromium.org
BUG=589630
Committed: https://crrev.com/291a588fa70842b015465b1c0bef85d521829832
Cr-Commit-Position: refs/heads/master@{#382399}

[dschuyler, 2016-03-18 21:18:36]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[dschuyler, 2016-03-18 21:18:37]

The sheet at
https://docs.google.com/spreadsheets/d/1Rvc51Ia4WKVU82KXeDH-Icj8bQcoM3GDxo6zo...
has the list of items in-order, with the icon names.

The Google cloud print section is intentionally ommited
(until we have a cloud print section to match it).

[Dan Beam, 2016-03-18 21:22:10]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-03-18 21:22:11]

are these icons approved by tbuckley/bettes?

[bettes, 2016-03-18 22:42:00]

On 2016/03/18 21:22:11, Dan Beam wrote:
> are these icons approved by tbuckley/bettes?

LGTM

[tommycli, 2016-03-18 22:44:51]

code lgtm sans:

Just need to double check that we are "including what we use" in terms of the
icons import files.

https://codereview.chromium.org/1814033005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_menu/settings_menu.html (right):

https://codereview.chromium.org/1814033005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_menu/settings_menu.html:83:
<iron-icon icon="image:palette" item-icon></iron-icon>
Do you have to include image-icons in the imports now ?

https://codereview.chromium.org/1814033005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_menu/settings_menu.html:98:
<iron-icon icon="av:web" item-icon></iron-icon>
Same with av-icons in imports?

[dschuyler, 2016-03-18 23:14:11]

https://codereview.chromium.org/1814033005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_menu/settings_menu.html (right):

https://codereview.chromium.org/1814033005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_menu/settings_menu.html:83:
<iron-icon icon="image:palette" item-icon></iron-icon>
On 2016/03/18 22:44:50, tommycli wrote:
> Do you have to include image-icons in the imports now ?

Done.

https://codereview.chromium.org/1814033005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_menu/settings_menu.html:98:
<iron-icon icon="av:web" item-icon></iron-icon>
On 2016/03/18 22:44:51, tommycli wrote:
> Same with av-icons in imports?

Done.

[dschuyler, 2016-03-21 20:45:22]

Description was changed from

==========
[MD settings] change side nav icons

This CL changes several side nav icons and moves
the OnStartup section under the DefaultBrowser
section.

BUG=589630
==========

to

==========
[MD settings] change side nav icons

This CL changes several side nav icons and moves
the OnStartup section under the DefaultBrowser
section.

TBR=dbeam@chromium.org
BUG=589630
==========

[dschuyler, 2016-03-21 20:45:34]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-03-21 20:45:35]

The patchset sent to the CQ was uploaded after l-g-t-m from bettes@google.com,
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/1814033005/#ps20001
(title: "review change")

[commit-bot: I haz the power, 2016-03-21 20:46:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814033005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814033005/20001

[commit-bot: I haz the power, 2016-03-21 21:44:51]

Description was changed from

==========
[MD settings] change side nav icons

This CL changes several side nav icons and moves
the OnStartup section under the DefaultBrowser
section.

TBR=dbeam@chromium.org
BUG=589630
==========

to

==========
[MD settings] change side nav icons

This CL changes several side nav icons and moves
the OnStartup section under the DefaultBrowser
section.

TBR=dbeam@chromium.org
BUG=589630
==========

[commit-bot: I haz the power, 2016-03-21 21:44:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-21 21:46:08]

Description was changed from

==========
[MD settings] change side nav icons

This CL changes several side nav icons and moves
the OnStartup section under the DefaultBrowser
section.

TBR=dbeam@chromium.org
BUG=589630
==========

to

==========
[MD settings] change side nav icons

This CL changes several side nav icons and moves
the OnStartup section under the DefaultBrowser
section.

TBR=dbeam@chromium.org
BUG=589630

Committed: https://crrev.com/291a588fa70842b015465b1c0bef85d521829832
Cr-Commit-Position: refs/heads/master@{#382399}
==========

[commit-bot: I haz the power, 2016-03-21 21:46:09]

Patchset 2 (id:??) landed as
https://crrev.com/291a588fa70842b015465b1c0bef85d521829832
Cr-Commit-Position: refs/heads/master@{#382399}