Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1814033004: Record slots in the string table to avoid iterating it twice. (Closed)

Created:
4 years, 9 months ago by ulan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Record slots in the string table to avoid iterating it twice. Currently we iterate the string table to clear non-live references and to update pointers. We can skip the second iteration if we record slots. BUG= Committed: https://crrev.com/6479d4264a6017401549ab7d2105ae3cc258456d Cr-Commit-Position: refs/heads/master@{#34936}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M src/heap/mark-compact.cc View 1 4 chunks +25 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ulan
PTAL. This reduces average GC pause in v8.infinite_scroll by ~0.2ms.
4 years, 9 months ago (2016-03-18 15:20:24 UTC) #2
Hannes Payer (out of office)
lgtm
4 years, 9 months ago (2016-03-21 09:56:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814033004/1
4 years, 9 months ago (2016-03-21 09:58:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/12183)
4 years, 9 months ago (2016-03-21 10:03:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814033004/20001
4 years, 9 months ago (2016-03-21 11:08:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 13:26:52 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 13:28:29 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6479d4264a6017401549ab7d2105ae3cc258456d
Cr-Commit-Position: refs/heads/master@{#34936}

Powered by Google App Engine
This is Rietveld 408576698