Add source kind to the incremental cache.

Add source kind to the incremental cache.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/8f265d90f0908f091c8fa6f3ae0aa99ab04f0d2b

[Brian Wilkerson, 2016-03-18 17:39:51]

Description was changed from

==========
Add source kind to the incremental cache.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Add source kind to the incremental cache.

R=paulberry@google.com
BUG=
==========

[Brian Wilkerson, 2016-03-18 17:39:51]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com
- brianwilkerson@google.com

[Brian Wilkerson, 2016-03-18 17:40:27]

I'm going to hand this over to Paul.

[Paul Berry, 2016-03-18 18:38:14]

lgtm

https://codereview.chromium.org/1814013004/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1814013004/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:65: * or `package:foo/bar.dart`.
Document what happens to this field when [kind] is CacheSourceKind.part.  (I
assume it's empty?)

https://codereview.chromium.org/1814013004/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:72: * or `package:foo/bar.dart`.
Same here

https://codereview.chromium.org/1814013004/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/1814013004/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:274:
_writeCacheSourceContent(part.source,
As per our discussion, this could corrupt the cache in the event that there is
invalid code.  For example:

a.dart:
import 'b.dart';
part 'c.dart';

b.dart:
import 'c.dart';

c.dart:
...

c.dart will first be inserted into the cache as a part, then it will be inserted
into the cache as a library (overwriting the old data).  Let's say c.dart is
actually intended to be a part.  If the user tries to correct the error by
removing the line "import 'c.dart';", then the cache will still say that c.dart
is a library.

If you'd like to address this in a future CL, please add a TODO comment so that
we don't forget about this corner case.

[scheglov, 2016-03-18 19:41:43]

Description was changed from

==========
Add source kind to the incremental cache.

R=paulberry@google.com
BUG=
==========

to

==========
Add source kind to the incremental cache.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/8f265d90f0908f091c8fa6f3ae0aa99ab04f0d2b
==========

[scheglov, 2016-03-18 19:41:45]

Committed patchset #1 (id:1) manually as
8f265d90f0908f091c8fa6f3ae0aa99ab04f0d2b (presubmit successful).

[scheglov, 2016-03-18 19:42:06]

https://codereview.chromium.org/1814013004/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1814013004/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:65: * or `package:foo/bar.dart`.
On 2016/03/18 18:38:14, Paul Berry wrote:
> Document what happens to this field when [kind] is CacheSourceKind.part.  (I
> assume it's empty?)

Done.

https://codereview.chromium.org/1814013004/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:72: * or `package:foo/bar.dart`.
On 2016/03/18 18:38:14, Paul Berry wrote:
> Same here

Done.

https://codereview.chromium.org/1814013004/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/incremental_cache.dart (right):

https://codereview.chromium.org/1814013004/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/incremental_cache.dart:274:
_writeCacheSourceContent(part.source,
On 2016/03/18 18:38:14, Paul Berry wrote:
> As per our discussion, this could corrupt the cache in the event that there is
> invalid code.  For example:
> 
> a.dart:
> import 'b.dart';
> part 'c.dart';
> 
> b.dart:
> import 'c.dart';
> 
> c.dart:
> ...
> 
> c.dart will first be inserted into the cache as a part, then it will be
inserted
> into the cache as a library (overwriting the old data).  Let's say c.dart is
> actually intended to be a part.  If the user tries to correct the error by
> removing the line "import 'c.dart';", then the cache will still say that
c.dart
> is a library.
> 
> If you'd like to address this in a future CL, please add a TODO comment so
that
> we don't forget about this corner case.

Done.