third_party/WebKit/LayoutTests/fast/dom/viewport/visualviewportchanged-event-fired.html - Issue 1814013002: Visual viewport API initial implementation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/visualviewportchanged-event-fired.html

Issue 1814013002: Visual viewport API initial implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/dom/viewport/visualviewportchanged-event-fired-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/js-test.js"></script>

	3 <style>

	4 body {

	5 height: 2000px;

	6 width: 2000px;

	7 }

	8 </style>

	9

	10 <script>

	11 window.jsTestIsAsync = true;

	12 var numCalls = 0;

	13

	14 description("This test verifies that that visualviewportchanged event gets \

	15 fired when the visual viewport is scaled or scrolled.");

	16

	17 function runTest() {

	18 if (!window.eventSender \|\| !window.internals) {

	19 finishJSTest();

	20 return;

	21 }

	22 // Turn off smooth scrolling.

	23 internals.settings.setScrollAnimatorEnabled(false);

	24

	25 document.addEventListener('visualviewportchanged', function(e) {

	26 numCalls++;

	27 });

	28

	29 // visualviewportchanged is non-bubbling.
	bokan 2016/03/22 21:34:21 I don't think you need this, document is above doc I don't think you need this, document is above documentElement. ymalik 2016/03/23 00:13:44 Done. Show quoted text On 2016/03/22 21:34:21, bokan wrote: > I don't think you need this, document is above documentElement. Done.
	30 document.documentElement.addEventListener('visualviewportchanged', funct ion(event) {

	31 debug("visualviewportchanged erroneously called on document");

	32 })

	33

	34 // Scroll both viewports. Listner not called.

	35 eventSender.mouseMoveTo(100, 100);

	36 eventSender.continuousMouseScrollBy(100, 100);
	bokan 2016/03/22 21:34:21 check numCalls == 0 here. check numCalls == 0 here. ymalik 2016/03/23 00:13:44 Done. Show quoted text On 2016/03/22 21:34:21, bokan wrote: > check numCalls == 0 here. Done.
	37

	38 // Scale and scroll visual viewport. Listener called twice.

	39 internals.setPageScaleFactor(2);

	40 shouldBe("numCalls", "1");

	41 internals.setVisualViewportOffset(10, 10);

	42 shouldBe("numCalls", "2");

	43

	44 // Set viewport offset. Listener called twice.

	45 document.visualViewport.scrollTop = 20;

	46 shouldBe("numCalls", "3");

	47 document.visualViewport.scrollLeft = 0;

	48 shouldBe("numCalls", "4");

	49 finishJSTest();

	50 }

	51 </script>

	52

	53 <body onload="runTest()"></body>

OLD	NEW