content/renderer/dom_storage/local_storage_cached_areas.h - Issue 1814003002: Implement the renderer side of the mojo based local storage implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/dom_storage/local_storage_cached_areas.h

Issue 1814003002: Implement the renderer side of the mojo based local storage implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/dom_storage/local_storage_cached_area.cc ('K') | « content/renderer/dom_storage/local_storage_cached_area.cc ('k') | content/renderer/dom_storage/local_storage_cached_areas.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/dom_storage/local_storage_cached_areas.h

diff --git a/content/renderer/dom_storage/local_storage_cached_areas.h b/content/renderer/dom_storage/local_storage_cached_areas.h

index fba1daa4eed32c195a97dd05ca634c6773dc3c08..3d7ec0707bbe0509dcbfaa82caddd169fe085bbf 100644

--- a/content/renderer/dom_storage/local_storage_cached_areas.h

+++ b/content/renderer/dom_storage/local_storage_cached_areas.h

@@ -25,11 +25,12 @@ class LocalStorageCachedAreas {

StoragePartitionService* storage_partition_service);

~LocalStorageCachedAreas();

- scoped_refptr<LocalStorageCachedArea> GetLocalStorageCachedArea(

- const url::Origin& origin);

+ // Returns, creating if necessary, a cached storage area for the given origin.

+ scoped_refptr<LocalStorageCachedArea>

+ GetCachedArea(const url::Origin& origin);

// Called by LocalStorageCachedArea on destruction.

- void LocalStorageCacheAreaClosed(LocalStorageCachedArea* cached_area);

+ void CacheAreaClosed(LocalStorageCachedArea* cached_area);

private:

StoragePartitionService* const storage_partition_service_;