Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1813983003: Revert "Add dev_compiler to the SDK build process." (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add dev_compiler to the SDK build process." This broke the Mac and Windows builds, for reasons I'm still investigating. This reverts commit 2ddf2448195b0489ffa9b4245c123dacb0230848. TBR=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/ceec063f27b6bde552cf22193aa2ba4e3d310c15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -168 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M create_sdk.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M dart.gyp View 2 chunks +0 lines, -8 lines 0 comments Download
D sdk/bin/dartdevc View 1 chunk +0 lines, -86 lines 0 comments Download
D sdk/bin/dartdevc_sdk View 1 chunk +0 lines, -31 lines 0 comments Download
M tools/create_sdk.py View 3 chunks +2 lines, -4 lines 0 comments Download
D utils/dartdevc/dartdevc.gyp View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Paul Berry
4 years, 9 months ago (2016-03-17 20:46:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ceec063f27b6bde552cf22193aa2ba4e3d310c15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698