Don't upgrade the severity of *everything* to an error in strong mode.

Don't upgrade the severity of *everything* to an error in strong mode.

Oops!

Fixes #26026.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/a602585097aec147fc5cd3cbf93fc26b38b79dbf

[Bob Nystrom, 2016-03-17 19:48:18]

Description was changed from

==========
Don't upgrade the severity of *everything* to an error in strong mode.

Oops!
==========

to

==========
Don't upgrade the severity of *everything* to an error in strong mode.

Oops!

Fixes #26026.
==========

[Bob Nystrom, 2016-03-17 19:48:25]

rnystrom@google.com changed reviewers:
+ brianwilkerson@google.com, pquitslund@google.com

[Brian Wilkerson, 2016-03-17 19:54:14]

LGTM

https://codereview.chromium.org/1813973002/diff/1/pkg/analyzer/lib/source/err...
File pkg/analyzer/lib/source/error_processor.dart (right):

https://codereview.chromium.org/1813973002/diff/1/pkg/analyzer/lib/source/err...
pkg/analyzer/lib/source/error_processor.dart:103: processors =
processors.toList();
It looks like it should already be a list. Is 'getConfigurationData' returning
something other than a list (in which case the 'toList' might want to be moved
up a couple of lines)?

[Bob Nystrom, 2016-03-17 19:58:25]

https://codereview.chromium.org/1813973002/diff/1/pkg/analyzer/lib/source/err...
File pkg/analyzer/lib/source/error_processor.dart (right):

https://codereview.chromium.org/1813973002/diff/1/pkg/analyzer/lib/source/err...
pkg/analyzer/lib/source/error_processor.dart:103: processors =
processors.toList();
On 2016/03/17 19:54:14, Brian Wilkerson wrote:
> It looks like it should already be a list. Is 'getConfigurationData' returning
> something other than a list (in which case the 'toList' might want to be moved
> up a couple of lines)?

It is a list, but I want to copy it so I don't mutate the original one with the
.add() call.

[Bob Nystrom, 2016-03-17 19:58:26]

Description was changed from

==========
Don't upgrade the severity of *everything* to an error in strong mode.

Oops!

Fixes #26026.
==========

to

==========
Don't upgrade the severity of *everything* to an error in strong mode.

Oops!

Fixes #26026.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a602585097aec147fc5cd3cbf93fc26b38b79dbf
==========

[Bob Nystrom, 2016-03-17 19:58:31]

Committed patchset #1 (id:1) manually as
a602585097aec147fc5cd3cbf93fc26b38b79dbf (presubmit successful).

[pquitslund, 2016-03-17 20:16:41]

Late to the party, but LGTM!