Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1813943004: Fix dangling pointer (Closed)

Created:
4 years, 9 months ago by zra
Modified:
4 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix dangling pointer The resolved executable path is returned to the static in Platform as a scope allocated string. This change strdups it when it is cached in a static for return on subsequent calls. Previously, the memory would be deallocated on exit from the scope. fixes #26031 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/078d89ef5c2fc431cd8b5926d61783f109391cf9

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M runtime/bin/platform.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/platform.cc View 1 chunk +1 line, -1 line 0 comments Download
A tests/standalone/regress_26031_test.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
4 years, 9 months ago (2016-03-18 05:49:47 UTC) #3
siva
lgtm
4 years, 9 months ago (2016-03-18 14:56:16 UTC) #4
zra
4 years, 9 months ago (2016-03-18 15:34:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
078d89ef5c2fc431cd8b5926d61783f109391cf9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698