Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1813943003: DevTools: automatic mapping detection is broken for cases with specific file paths. (Closed)

Created:
4 years, 9 months ago by pfeldman
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: automatic mapping detection is broken for cases with specific file paths. BUG=595347 Committed: https://crrev.com/ca1179ee182e37f4b70d0cce280a46ffa62ce98d Cr-Commit-Position: refs/heads/master@{#382092}

Patch Set 1 #

Patch Set 2 : added expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/inspector/file-system-mapping.html View 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-mapping-expected.txt View 1 12 chunks +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/FileSystemMapping.js View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
pfeldman
4 years, 9 months ago (2016-03-17 22:50:52 UTC) #2
dgozman
expectations missing
4 years, 9 months ago (2016-03-18 00:46:04 UTC) #3
pfeldman
ouch
4 years, 9 months ago (2016-03-18 04:14:36 UTC) #4
pfeldman
PTAL
4 years, 9 months ago (2016-03-18 18:33:11 UTC) #5
dgozman
lgtm
4 years, 9 months ago (2016-03-18 18:49:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813943003/20001
4 years, 9 months ago (2016-03-18 18:50:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 21:22:00 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 21:23:16 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ca1179ee182e37f4b70d0cce280a46ffa62ce98d
Cr-Commit-Position: refs/heads/master@{#382092}

Powered by Google App Engine
This is Rietveld 408576698