dm/DM.cpp - Issue 1813933002: just write the verbose log file any time we have a --writePath

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DM.cpp

Issue 1813933002: just write the verbose log file any time we have a --writePath (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DM.cpp

diff --git a/dm/DM.cpp b/dm/DM.cpp

index 3a7ba77a3dd56867766c5738b6d2a46f52dbc191..24c47992e3b730df404b38ceeedb47c9c5457a34 100644

--- a/dm/DM.cpp

+++ b/dm/DM.cpp

@@ -1311,7 +1311,7 @@ int dm_main();

int dm_main() {

setup_crash_handler();

- if (FLAGS_verbose && !FLAGS_writePath.isEmpty()) {

+ if (!FLAGS_writePath.isEmpty()) {

sk_mkdir(FLAGS_writePath[0]);

gVLog = freopen(SkOSPath::Join(FLAGS_writePath[0], "verbose.log").c_str(), "w", stderr);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »