Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1813913004: An undefined literal should match as an undefined literal. (Closed)

Created:
4 years, 9 months ago by mvstanton
Modified:
4 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

An undefined literal should match as an undefined literal. Just sayin'. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/d6ad4c7f1ff501da98bc624495b788f32f47cf26 Cr-Commit-Position: refs/heads/master@{#34901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/ast/ast.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Thanks for the look! --Mike
4 years, 9 months ago (2016-03-18 16:25:36 UTC) #1
Michael Starzinger
LGTM.
4 years, 9 months ago (2016-03-18 16:30:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813913004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813913004/1
4 years, 9 months ago (2016-03-18 16:37:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 16:48:37 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 16:49:36 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d6ad4c7f1ff501da98bc624495b788f32f47cf26
Cr-Commit-Position: refs/heads/master@{#34901}

Powered by Google App Engine
This is Rietveld 408576698