Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1813883002: Disable idle player suspend on OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: if/else. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 8d58384a7b40532f3a82898b511ebc3fba5f9e4e..64a44f770d4990fecbb35f8ce4b99328774cdd9f 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -1105,6 +1105,12 @@ void WebMediaPlayerImpl::OnSuspendRequested(bool must_suspend) {
return;
#endif
+#if defined(OS_MACOSX)
+ // TODO(sandersd): Idle suspend is disabled on OSX since hardware decoded
+ // frames are owned by the video decoder in the GPU process. A mechanism for
+ // detaching ownership from the decoder is needed. http://crbug.com/595716.
+ return;
+#else
// Suspend should never be requested unless required or we're already in an
// idle state (paused or ended).
DCHECK(must_suspend || paused_ || ended_);
@@ -1115,6 +1121,7 @@ void WebMediaPlayerImpl::OnSuspendRequested(bool must_suspend) {
pipeline_controller_.Suspend();
if (must_suspend && delegate_)
delegate_->PlayerGone(delegate_id_);
+#endif
}
void WebMediaPlayerImpl::OnPlay() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698