Add report URL to safe search API functionality.

Add report URL to safe search API functionality.

Add apiary request creator that gets the appropriate auth token and
sends a request ot the SafeSearch API.
Currently this is attached to supervised user services and a child
will be able to issue such request.
I have added feature flags that disable the apiary creator from
being added to the supervised user services and this disables the
whole feature.

BUG=595748
Committed: https://crrev.com/ac676033b595286702fd2c56183b87c85ce7574a
Cr-Commit-Position: refs/heads/master@{#385190}

[atanasova, 2016-03-17 17:21:35]

Description was changed from

==========
Add report URL to safe search API functionality.

Add apiary request creator that gets the appropriate auth token and
sends a request ot the SafeSearch API.
Currently this is attached to supervised user services and a child
will be able to issue such request.
I have added feature flags that disable the apiary creator from
being added to the supervised user services and this disables the
whole feature.

BUG=595748
==========

to

==========
Add report URL to safe search API functionality.

Add apiary request creator that gets the appropriate auth token and
sends a request ot the SafeSearch API.
Currently this is attached to supervised user services and a child
will be able to issue such request.
I have added feature flags that disable the apiary creator from
being added to the supervised user services and this disables the
whole feature.

BUG=595748
==========

[atanasova, 2016-03-17 17:21:35]

atanasova@chromium.org changed reviewers:
+ pamg@chromium.org, treib@chromium.org

[Marc Treib, 2016-03-18 11:28:54]

https://codereview.chromium.org/1813833002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1813833002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:4977: +        Enable report URL to
SafeSearch API
Somehow I find this sentence super hard to parse. Can we do something like
"Enable SafeSearch URL reporting" for the short and "If enabled, inappropriate
URLs can be reported back to SafeSearch."?

https://codereview.chromium.org/1813833002/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/report_url_request_creator.h (right):

https://codereview.chromium.org/1813833002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/report_url_request_creator.h:12: class
ReportUrlRequestCreator {
"RequestCreator" isn't really appropriate here, nothing is requested or created.
"SafeSearchUrlReporter" or something like that?

https://codereview.chromium.org/1813833002/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/supervised_user_service.h (right):

https://codereview.chromium.org/1813833002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_service.h:187: void
AddReportUrlRequestCreator(scoped_ptr<ReportUrlRequestCreator> creator);
All this complexity with a "RequestCreator" interface, and handling multiple
instances of them in the SUService, isn't necessary here. There will only ever
be one of them, and there is only one possible implementation (in contrast to
permission requests, which have different implementations for legacy SUs vs.
child accounts).

https://codereview.chromium.org/1813833002/diff/1/chrome/common/chrome_featur...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/1813833002/diff/1/chrome/common/chrome_featur...
chrome/common/chrome_features.cc:31: "ReportUrlSafeSearch",
base::FEATURE_DISABLED_BY_DEFAULT
Similar to the flag names.. maybe "SafeSearchReporting" or
"SafeSearchUrlReporting"?

[atanasova, 2016-03-21 10:42:25]

Did a refactor on how the code works overall and renamed the files and classes.
Now I am not expecting more than one reporter, so changed the logic around that

https://codereview.chromium.org/1813833002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1813833002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:4977: +        Enable report URL to
SafeSearch API
On 2016/03/18 11:28:54, Marc Treib wrote:
> Somehow I find this sentence super hard to parse. Can we do something like
> "Enable SafeSearch URL reporting" for the short and "If enabled, inappropriate
> URLs can be reported back to SafeSearch."?

Done.

https://codereview.chromium.org/1813833002/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/report_url_request_creator.h (right):

https://codereview.chromium.org/1813833002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/report_url_request_creator.h:12: class
ReportUrlRequestCreator {
On 2016/03/18 11:28:54, Marc Treib wrote:
> "RequestCreator" isn't really appropriate here, nothing is requested or
created.
> "SafeSearchUrlReporter" or something like that?

Done.

https://codereview.chromium.org/1813833002/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/supervised_user_service.h (right):

https://codereview.chromium.org/1813833002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_service.h:187: void
AddReportUrlRequestCreator(scoped_ptr<ReportUrlRequestCreator> creator);
On 2016/03/18 11:28:54, Marc Treib wrote:
> All this complexity with a "RequestCreator" interface, and handling multiple
> instances of them in the SUService, isn't necessary here. There will only ever
> be one of them, and there is only one possible implementation (in contrast to
> permission requests, which have different implementations for legacy SUs vs.
> child accounts).

Done.

https://codereview.chromium.org/1813833002/diff/1/chrome/common/chrome_featur...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/1813833002/diff/1/chrome/common/chrome_featur...
chrome/common/chrome_features.cc:31: "ReportUrlSafeSearch",
base::FEATURE_DISABLED_BY_DEFAULT
On 2016/03/18 11:28:54, Marc Treib wrote:
> Similar to the flag names.. maybe "SafeSearchReporting" or
> "SafeSearchUrlReporting"?

Done.

[Marc Treib, 2016-03-21 12:32:21]

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1697: {"enable-safe-search-url-reporting",
nit: I'd remove the "enable-" prefix, since it doesn't really add anything.
(Though lots of other flags do use it, so meh...)

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc
(right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc:63: :
OAuth2TokenService::Consumer("report_url"),
"safe_search_url_reporter"?

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/experimental/safe_search_url_reporter.h
(right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
2016 :)

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:8:
#include <stddef.h>
probably not needed?

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:14:
#include "base/containers/mru_cache.h"
not needed

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:34:
typedef base::Callback<void(bool)> SuccessCallback;
nit: I prefer
using SuccessCallback = ...

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:65: int
url_fetcher_id_;
Optional: I think all of these can be const.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
File
chrome/browser/supervised_user/experimental/safe_search_url_reporter_unittest.cc
(left):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter_unittest.cc:104:
// We should have gotten a request for an access token.
Any reason for not keeping the comments?

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
File
chrome/browser/supervised_user/experimental/safe_search_url_reporter_unittest.cc
(right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter_unittest.cc:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter_unittest.cc:72:
MOCK_METHOD1(OnRequestCreated, void(bool sucess));
typo :)

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_service.h (right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_service.h:124: // Reports url to
the SafeSearch API.
|url| (pipes around the variable name)

I'd also add some explanation on the semantics of "report", i.e. the user thinks
this is an inappropriate URL.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_service.h:125: void
ReportUrl(const GURL& url, const SuccessCallback& callback);
nit: ReportURL (capitalized), to be consistent with the method above.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_service.h:187: void
SetSafeSearchUrlReporter(scoped_ptr<SafeSearchUrlReporter> creator);
s/creator/reporter/

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_service.h:407: // Used to create
report url requests.
"Used to report inappropriate URLs to the SafeSearch API"?

https://codereview.chromium.org/1813833002/diff/20001/chrome/common/chrome_fe...
File chrome/common/chrome_features.h (right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/common/chrome_fe...
chrome/common/chrome_features.h:28: extern const base::Feature
kSafeSearchUrlReporting;
nit: move after kRuntime... to keep things alphabetized.

[atanasova, 2016-03-22 15:45:41]

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1697: {"enable-safe-search-url-reporting",
On 2016/03/21 12:32:21, Marc Treib wrote:
> nit: I'd remove the "enable-" prefix, since it doesn't really add anything.
> (Though lots of other flags do use it, so meh...)

Since the flag will be used for enabling the feature (disabled by default), I
think that this keeps the style of the other flags.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc
(right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
On 2016/03/21 12:32:21, Marc Treib wrote:
> 2016

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.cc:63: :
OAuth2TokenService::Consumer("report_url"),
On 2016/03/21 12:32:21, Marc Treib wrote:
> "safe_search_url_reporter"?

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/experimental/safe_search_url_reporter.h
(right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
On 2016/03/21 12:32:21, Marc Treib wrote:
> 2016 :)

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:8:
#include <stddef.h>
On 2016/03/21 12:32:21, Marc Treib wrote:
> probably not needed?

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:14:
#include "base/containers/mru_cache.h"
On 2016/03/21 12:32:21, Marc Treib wrote:
> not needed

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:34:
typedef base::Callback<void(bool)> SuccessCallback;
On 2016/03/21 12:32:21, Marc Treib wrote:
> nit: I prefer
> using SuccessCallback = ...

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:65: int
url_fetcher_id_;
On 2016/03/21 12:32:21, Marc Treib wrote:
> Optional: I think all of these can be const.

Actually the methods that are using them do not work when using const and others
do need to be changed.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
File
chrome/browser/supervised_user/experimental/safe_search_url_reporter_unittest.cc
(right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter_unittest.cc:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
On 2016/03/21 12:32:21, Marc Treib wrote:
> 2016

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter_unittest.cc:72:
MOCK_METHOD1(OnRequestCreated, void(bool sucess));
On 2016/03/21 12:32:21, Marc Treib wrote:
> typo :)

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/supervised_user_service.h (right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_service.h:124: // Reports url to
the SafeSearch API.
On 2016/03/21 12:32:21, Marc Treib wrote:
> |url| (pipes around the variable name)
> 
> I'd also add some explanation on the semantics of "report", i.e. the user
thinks
> this is an inappropriate URL.

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_service.h:125: void
ReportUrl(const GURL& url, const SuccessCallback& callback);
On 2016/03/21 12:32:21, Marc Treib wrote:
> nit: ReportURL (capitalized), to be consistent with the method above.

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_service.h:187: void
SetSafeSearchUrlReporter(scoped_ptr<SafeSearchUrlReporter> creator);
On 2016/03/21 12:32:21, Marc Treib wrote:
> s/creator/reporter/

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/supervised_user_service.h:407: // Used to create
report url requests.
On 2016/03/21 12:32:21, Marc Treib wrote:
> "Used to report inappropriate URLs to the SafeSearch API"?

Done.

https://codereview.chromium.org/1813833002/diff/20001/chrome/common/chrome_fe...
File chrome/common/chrome_features.h (right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/common/chrome_fe...
chrome/common/chrome_features.h:28: extern const base::Feature
kSafeSearchUrlReporting;
On 2016/03/21 12:32:21, Marc Treib wrote:
> nit: move after kRuntime... to keep things alphabetized.

Done.

[Marc Treib, 2016-03-22 16:06:50]

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1697: {"enable-safe-search-url-reporting",
On 2016/03/22 15:45:41, atanasova wrote:
> On 2016/03/21 12:32:21, Marc Treib wrote:
> > nit: I'd remove the "enable-" prefix, since it doesn't really add anything.
> > (Though lots of other flags do use it, so meh...)
> 
> Since the flag will be used for enabling the feature (disabled by default), I
> think that this keeps the style of the other flags.

If it's enabled or disabled by default can change though. (And hopefully will,
at some point :) )
Anyway, since this is a FEATURE_VALUE_TYPE, all the name does is define the
anchor on chrome://flags, as in chrome://flags#enable-safe-search-url-reporting

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1699:
IDS_FLAGS_ENABLE_SAFE_SEARCH_URL_REPORTING_DESCRIPTION, kOsDesktop,
I just noticed: Why not kOsAll?

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
File chrome/browser/supervised_user/experimental/safe_search_url_reporter.h
(right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:65: int
url_fetcher_id_;
On 2016/03/22 15:45:41, atanasova wrote:
> On 2016/03/21 12:32:21, Marc Treib wrote:
> > Optional: I think all of these can be const.
> 
> Actually the methods that are using them do not work when using const and
others
> do need to be changed.

Acknowledged.

https://codereview.chromium.org/1813833002/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1813833002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:4976: +      <message
name="IDS_FLAGS_ENABLE_SAFE_SEARCH_URL_REPORTING_DESCRIPTION" desc="Description
for the flag to enable reporting URL to SafeSearch API.">
nit: URLs

https://codereview.chromium.org/1813833002/diff/40001/chrome/browser/supervis...
File chrome/browser/supervised_user/experimental/safe_search_url_reporter.h
(right):

https://codereview.chromium.org/1813833002/diff/40001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:23: class
SafeSearchUrlReporter : public OAuth2TokenService::Consumer,
Also here: URL capitalized

[atanasova, 2016-03-23 10:45:01]

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1697: {"enable-safe-search-url-reporting",
On 2016/03/22 16:06:49, Marc Treib wrote:
> On 2016/03/22 15:45:41, atanasova wrote:
> > On 2016/03/21 12:32:21, Marc Treib wrote:
> > > nit: I'd remove the "enable-" prefix, since it doesn't really add
anything.
> > > (Though lots of other flags do use it, so meh...)
> > 
> > Since the flag will be used for enabling the feature (disabled by default),
I
> > think that this keeps the style of the other flags.
> 
> If it's enabled or disabled by default can change though. (And hopefully will,
> at some point :) )
> Anyway, since this is a FEATURE_VALUE_TYPE, all the name does is define the
> anchor on chrome://flags, as in
chrome://flags#enable-safe-search-url-reporting

Okay, you convinced me. Removed the 'enable' here and the string that are used.

https://codereview.chromium.org/1813833002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1699:
IDS_FLAGS_ENABLE_SAFE_SEARCH_URL_REPORTING_DESCRIPTION, kOsDesktop,
On 2016/03/22 16:06:49, Marc Treib wrote:
> I just noticed: Why not kOsAll?

I was trying it out first on desktop only, but agreed that it does make sense to
have it everywhere.

https://codereview.chromium.org/1813833002/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1813833002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:4976: +      <message
name="IDS_FLAGS_ENABLE_SAFE_SEARCH_URL_REPORTING_DESCRIPTION" desc="Description
for the flag to enable reporting URL to SafeSearch API.">
On 2016/03/22 16:06:49, Marc Treib wrote:
> nit: URLs

Done here and above in the actual name.

https://codereview.chromium.org/1813833002/diff/40001/chrome/browser/supervis...
File chrome/browser/supervised_user/experimental/safe_search_url_reporter.h
(right):

https://codereview.chromium.org/1813833002/diff/40001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:23: class
SafeSearchUrlReporter : public OAuth2TokenService::Consumer,
On 2016/03/22 16:06:49, Marc Treib wrote:
> Also here: URL capitalized

Done.

[Marc Treib, 2016-03-23 10:48:42]

LGTM, thanks for putting up with all my naming nits! :)

https://codereview.chromium.org/1813833002/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1813833002/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:4974: +        Enable SafeSearch URLs
reporting.
Optionally, you could now also remove the "Enable" from the actual string :)

[atanasova, 2016-03-23 10:50:58]

https://codereview.chromium.org/1813833002/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1813833002/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:4974: +        Enable SafeSearch URLs
reporting.
On 2016/03/23 10:48:42, Marc Treib wrote:
> Optionally, you could now also remove the "Enable" from the actual string :)

Done.

[Pam (message me for reviews), 2016-03-23 18:31:47]

pam@chromium.org changed reviewers:
+ pam@chromium.org

[Pam (message me for reviews), 2016-03-23 18:31:48]

LGTM, with a couple of nits described below.

https://codereview.chromium.org/1813833002/diff/80001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1813833002/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:4973: +      <message
name="IDS_FLAGS_SAFE_SEARCH_URL_REPORTING_NAME" desc="Name for the flag to
enable reporting URLs to SafeSearch API.">
Nit: Just reporting them to SafeSearch (via the API, but not really _to_ it).
(Both descriptions.)

https://codereview.chromium.org/1813833002/diff/80001/chrome/browser/supervis...
File chrome/browser/supervised_user/experimental/safe_search_url_reporter.h
(right):

https://codereview.chromium.org/1813833002/diff/80001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:31: using
SuccessCallback = base::Callback<void(bool)>;
nit: By the style guide, this goes above the ctor.

[atanasova, 2016-03-23 18:45:02]

Adding @thakis for owners approval on changes in the chrome_features files.

For context - I am adding a new feature in chrome that will be use on all
platforms, so that is why I chose this place for it.

https://codereview.chromium.org/1813833002/diff/80001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1813833002/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:4973: +      <message
name="IDS_FLAGS_SAFE_SEARCH_URL_REPORTING_NAME" desc="Name for the flag to
enable reporting URLs to SafeSearch API.">
On 2016/03/23 18:31:48, Pam (also PM for reviews) wrote:
> Nit: Just reporting them to SafeSearch (via the API, but not really _to_ it).
> (Both descriptions.)

Done.

https://codereview.chromium.org/1813833002/diff/80001/chrome/browser/supervis...
File chrome/browser/supervised_user/experimental/safe_search_url_reporter.h
(right):

https://codereview.chromium.org/1813833002/diff/80001/chrome/browser/supervis...
chrome/browser/supervised_user/experimental/safe_search_url_reporter.h:31: using
SuccessCallback = base::Callback<void(bool)>;
On 2016/03/23 18:31:48, Pam (also PM for reviews) wrote:
> nit: By the style guide, this goes above the ctor.

Done.

[atanasova, 2016-03-23 18:45:26]

atanasova@chromium.org changed reviewers:
+ thakis@chromium.org

[atanasova, 2016-03-30 16:25:57]

Friendly ping

[Nico, 2016-04-05 14:41:18]

lgtm

[atanasova, 2016-04-05 14:42:13]

The CQ bit was checked by atanasova@chromium.org

[atanasova, 2016-04-05 14:42:13]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org,
pam@chromium.org
Link to the patchset: https://codereview.chromium.org/1813833002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-04-05 14:42:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1813833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1813833002/100001

[commit-bot: I haz the power, 2016-04-05 14:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 14:55:23]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[atanasova, 2016-04-05 15:26:48]

The CQ bit was checked by atanasova@chromium.org

[atanasova, 2016-04-05 15:26:48]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org,
thakis@chromium.org, pam@chromium.org
Link to the patchset: https://codereview.chromium.org/1813833002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-04-05 15:26:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1813833002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1813833002/120001

[commit-bot: I haz the power, 2016-04-05 16:31:25]

Description was changed from

==========
Add report URL to safe search API functionality.

Add apiary request creator that gets the appropriate auth token and
sends a request ot the SafeSearch API.
Currently this is attached to supervised user services and a child
will be able to issue such request.
I have added feature flags that disable the apiary creator from
being added to the supervised user services and this disables the
whole feature.

BUG=595748
==========

to

==========
Add report URL to safe search API functionality.

Add apiary request creator that gets the appropriate auth token and
sends a request ot the SafeSearch API.
Currently this is attached to supervised user services and a child
will be able to issue such request.
I have added feature flags that disable the apiary creator from
being added to the supervised user services and this disables the
whole feature.

BUG=595748
==========

[commit-bot: I haz the power, 2016-04-05 16:31:26]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-05 16:32:47]

Description was changed from

==========
Add report URL to safe search API functionality.

Add apiary request creator that gets the appropriate auth token and
sends a request ot the SafeSearch API.
Currently this is attached to supervised user services and a child
will be able to issue such request.
I have added feature flags that disable the apiary creator from
being added to the supervised user services and this disables the
whole feature.

BUG=595748
==========

to

==========
Add report URL to safe search API functionality.

Add apiary request creator that gets the appropriate auth token and
sends a request ot the SafeSearch API.
Currently this is attached to supervised user services and a child
will be able to issue such request.
I have added feature flags that disable the apiary creator from
being added to the supervised user services and this disables the
whole feature.

BUG=595748

Committed: https://crrev.com/ac676033b595286702fd2c56183b87c85ce7574a
Cr-Commit-Position: refs/heads/master@{#385190}
==========

[commit-bot: I haz the power, 2016-04-05 16:32:48]

Patchset 7 (id:??) landed as
https://crrev.com/ac676033b595286702fd2c56183b87c85ce7574a
Cr-Commit-Position: refs/heads/master@{#385190}