Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 181383017: [OriginChip, OSX] Hide on focus is switchable (Closed)

Created:
6 years, 9 months ago by groby-ooo-7-16
Modified:
6 years, 9 months ago
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

[OriginChip, OSX] Hide on focus is switchable Only hide the origin chip for an "OnSetFocus" event if the flag for hide-on-mouse-release is set. (hide-on-user-input is controlled by the OmniboxEditModel, so no additional work needed for that). BUG=338563 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254603

Patch Set 1 #

Patch Set 2 : Now with proper formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
groby-ooo-7-16
PTAL - this ensures we can choose either OriginChip behavior Gated on https://codereview.chromium.org/163913011/
6 years, 9 months ago (2014-02-27 23:34:12 UTC) #1
Justin Donnelly
On 2014/02/27 23:34:12, groby wrote: > PTAL - this ensures we can choose either OriginChip ...
6 years, 9 months ago (2014-02-28 15:54:29 UTC) #2
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 9 months ago (2014-02-28 16:15:54 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 16:16:29 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-02-28 16:16:30 UTC) #5
groby-ooo-7-16
Adding gbillock - PTAL
6 years, 9 months ago (2014-02-28 16:17:24 UTC) #6
Greg Billock
On 2014/02/28 16:17:24, groby wrote: > Adding gbillock - PTAL lgtm
6 years, 9 months ago (2014-03-03 17:31:54 UTC) #7
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 9 months ago (2014-03-03 17:32:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/181383017/20001
6 years, 9 months ago (2014-03-03 17:40:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/181383017/20001
6 years, 9 months ago (2014-03-03 18:29:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/181383017/20001
6 years, 9 months ago (2014-03-03 19:55:55 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 23:29:26 UTC) #12
Message was sent while issue was closed.
Change committed as 254603

Powered by Google App Engine
This is Rietveld 408576698