Issue 181383005: Revert 253439 "Make it possible to cancel commits following an a..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181383005: Revert 253439 "Make it possible to cancel commits following an a..." (Closed)

Created:
6 years, 9 months ago by Ryan Hamilton

Modified:
6 years, 9 months ago

Reviewers:
Sami

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 253439 "Make it possible to cancel commits following an a..." > Make it possible to cancel commits following an animation > > If we didn't invalidate anything when running main thread animations, there is > no need to continue with the commit. > > BUG=345584 > > Review URL: https://codereview.chromium.org/178123003 TBR=skyostil@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253507

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -92 lines)			Patch
M	trunk/src/cc/trees/layer_tree_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/cc/trees/layer_tree_host_unittest_animation.cc	View	2 chunks	+0 lines, -79 lines	0 comments	Download
M	trunk/src/cc/trees/thread_proxy.cc	View	3 chunks	+13 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

Committed patchset #1 manually as r253507 (tree was closed).

6 years, 9 months ago (2014-02-26 18:08:52 UTC) #2

danakj

On 2014/02/26 18:08:52, Ryan Hamilton wrote: > Committed patchset #1 manually as r253507 (tree was ...

6 years, 9 months ago (2014-02-26 18:25:07 UTC) #3

rch (use chromium not google)

6 years, 9 months ago (2014-02-26 18:29:43 UTC) #4

Message was sent while issue was closed.

On 2014/02/26 18:25:07, danakj wrote:
> On 2014/02/26 18:08:52, Ryan Hamilton wrote:
> > Committed patchset #1 manually as r253507 (tree was closed).
> 
> Can you please provide some information on why it was reverted here?

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...

Expand Messages | Collapse Messages