third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp - Issue 1813823002: Handle the case where the v8 scriptable object has a property defined with value undefined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

Issue 1813823002: Handle the case where the v8 scriptable object has a property defined with value undefined. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use shouldBeTrue in layout test and defines testGetUndefined in blink_deprecated_test_plugin.cc Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html ('K') | « third_party/WebKit/LayoutTests/plugins/plugin-scriptable-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

index 9e822865bf01303de5c8a28489329e3d4887a8bc..c07c7ab5dbc4e56ffe8fe678589c286bc6ccd1b6 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp

@@ -61,7 +61,7 @@ void getScriptableObjectProperty(PropertyType property, const v8::PropertyCallba

// We quit here to allow the binding code to look up general HTMLObjectElement properties

// if they are not overriden by plugin.

- if (value->IsUndefined())

+ if (value->IsUndefined() && !instance->Has(info.GetIsolate()->GetCurrentContext(), property).FromJust())

return;

v8SetReturnValue(info, value);