third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html - Issue 1813823002: Handle the case where the v8 scriptable object has a property defined with value undefined.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html

Issue 1813823002: Handle the case where the v8 scriptable object has a property defined with value undefined. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script>

	4 if (!window.testRunner) {

	5 document.write("This test does not work in manual mode.");

	6 } else {

	7 testRunner.dumpAsText()

	8 testRunner.waitUntilDone();

	9 }

	10

	11 function onLoad() {

	12 var plugin = document.getElementById("test");

	13 plugin.setAttribute("type", "application/x-blink-deprecated-test-plugin");

	14

	15 Object.defineProperties(plugin.testObject, {

	16 "p1": { get: function () { return undefined; } },

	17 "p2": {}

	18 });

	19

	20 if (plugin.hasOwnProperty("p1") && plugin.testObject.hasOwnProperty("p1") &&

	21 plugin.hasOwnProperty("p2") && plugin.testObject.hasOwnProperty("p2")) {

	22 document.getElementById('result').innerHTML = 'SUCCESS';
	bashi 2016/03/21 23:33:15 Printing SUCCESS is not the best way to show resul Printing SUCCESS is not the best way to show results. I'd suggest that using shouldBeXXX() helper functions which are defined in ../resources/js-test.js.
	23 }

	24

	25 testRunner.notifyDone();

	26 }

	27 </script>

	28 </head>

	29 <body onload="onLoad()">

	30 <div>This tests checks that hasOwnProperty return true on plugin's getters that return undefined and on plugin's properties defined with value undefined</div>

	31 <object id="test" type="application/x-blink-deprecated-test-plugin"></object>

	32 <div id="result">FAILURE</div>

	33 </body>

	34 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/plugins/plugin-scriptable-expected.txt » ('j') | no next file with comments »