Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1813813005: Timeline: fix overlapping group headers in Flame Chart (Closed)

Created:
4 years, 9 months ago by caseq
Modified:
4 years, 9 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: fix overlapping group headers in Flame Chart This fixes a corner case of group header rendering where we've computed group visibility wrong due to starting from non-top level group because of clipping. This patch simplifies logic to always traverse through all groups. BUG=595973 Committed: https://crrev.com/7db9ea7c5e05f1d82c6389eb7c9c23f17548c967 Cr-Commit-Position: refs/heads/master@{#382178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
caseq
4 years, 9 months ago (2016-03-18 22:18:30 UTC) #3
alph
lgtm
4 years, 9 months ago (2016-03-19 03:06:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813813005/1
4 years, 9 months ago (2016-03-19 03:06:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-19 04:18:13 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 04:42:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7db9ea7c5e05f1d82c6389eb7c9c23f17548c967
Cr-Commit-Position: refs/heads/master@{#382178}

Powered by Google App Engine
This is Rietveld 408576698