[compiler] Allocate SharedFunctionInfo before compile.

[compiler] Allocate SharedFunctionInfo before compile.

This changes the compilation pipeline so that SharedFunctionInfo objects
are always allocated before the various compilers are invoked. It is a
preparation towards having that object available during compile time and
hence reducing the dependency on FunctionLiteral and the need to copy a
lot of the information into the CompilationInfo.

Optimizing compilers already assume the SharedFunctionInfo is present
and the baseline compilers have other heap accesses sprinkled throughout
the compilation process. Duplicating statically available information
from the SharedFunctionInfo within the CompilationInfo has no benefit.

R=yangguo@chromium.org

Committed: https://crrev.com/42c8812d15a452fa1ace3b4cb87aea4373601937
Cr-Commit-Position: refs/heads/master@{#34885}

[Yang, 2016-03-18 06:35:25]

LGTM. Very nice!

https://codereview.chromium.org/1813803002/diff/40001/src/compiler.cc
File src/compiler.cc (left):

https://codereview.chromium.org/1813803002/diff/40001/src/compiler.cc#oldcode...
src/compiler.cc:1839: DCHECK(!existing->HasDebugCode());
Can we move this check to InstallBaselineCompilationResult?

[Michael Starzinger, 2016-03-18 10:05:17]

Thanks. Addressed comments. Landing now-ish.

https://codereview.chromium.org/1813803002/diff/40001/src/compiler.cc
File src/compiler.cc (left):

https://codereview.chromium.org/1813803002/diff/40001/src/compiler.cc#oldcode...
src/compiler.cc:1839: DCHECK(!existing->HasDebugCode());
On 2016/03/18 06:35:25, Yang wrote:
> Can we move this check to InstallBaselineCompilationResult?

Done.

[Michael Starzinger, 2016-03-18 10:37:12]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-03-18 10:37:13]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1813803002/#ps60001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-03-18 10:37:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1813803002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1813803002/60001

[commit-bot: I haz the power, 2016-03-18 10:46:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-18 10:48:16]

Description was changed from

==========
[compiler] Allocate SharedFunctionInfo before compile.

This changes the compilation pipeline so that SharedFunctionInfo objects
are always allocated before the various compilers are invoked. It is a
preparation towards having that object available during compile time and
hence reducing the dependency on FunctionLiteral and the need to copy a
lot of the information into the CompilationInfo.

Optimizing compilers already assume the SharedFunctionInfo is present
and the baseline compilers have other heap accesses sprinkled throughout
the compilation process. Duplicating statically available information
from the SharedFunctionInfo within the CompilationInfo has no benefit.

R=yangguo@chromium.org
==========

to

==========
[compiler] Allocate SharedFunctionInfo before compile.

This changes the compilation pipeline so that SharedFunctionInfo objects
are always allocated before the various compilers are invoked. It is a
preparation towards having that object available during compile time and
hence reducing the dependency on FunctionLiteral and the need to copy a
lot of the information into the CompilationInfo.

Optimizing compilers already assume the SharedFunctionInfo is present
and the baseline compilers have other heap accesses sprinkled throughout
the compilation process. Duplicating statically available information
from the SharedFunctionInfo within the CompilationInfo has no benefit.

R=yangguo@chromium.org

Committed: https://crrev.com/42c8812d15a452fa1ace3b4cb87aea4373601937
Cr-Commit-Position: refs/heads/master@{#34885}
==========

[commit-bot: I haz the power, 2016-03-18 10:48:17]

Patchset 4 (id:??) landed as
https://crrev.com/42c8812d15a452fa1ace3b4cb87aea4373601937
Cr-Commit-Position: refs/heads/master@{#34885}