Allows cpplints arguments to be used within gcl....

development/release/win/gcl.py

 #!/usr/bin/python
 # Wrapper script around Rietveld's upload.py that groups files into
 # changelists.
 
 import getpass
 import linecache
 import os
 import random
 import re
 import string
@@ skipping 710 matching lines @@
 
   change_info.Save()
   print change_info.name + " changelist saved."
 
 # We don't lint files in these path prefixes.
 IGNORE_PATHS = ("webkit",)
 
 # Valid extensions for files we want to lint.
 CPP_EXTENSIONS = ("cpp", "cc", "h")
 
-def Lint(change_info):
+def Lint(change_info, args):
   """Runs cpplint.py on all the files in |change_info|"""
   try:
     import cpplint
   except ImportError:
     ErrorExit("You need to install cpplint.py to lint C++ files.")
 
-  for file_record in change_info.files:
-    file = file_record[1]
+  # Change the current working directory before calling lint so that it
+  # shows the correct base.
+  os.chdir(GetRepositoryRoot())
 
+  # Process cpplints arguments if any.
+  filenames = cpplint.ParseArguments(args + change_info.FileList())
+
+  for file in filenames:
     if len([file for suffix in CPP_EXTENSIONS if file.endswith(suffix)]):
       if len([file for prefix in IGNORE_PATHS if file.startswith(prefix)]):
         print "Ignoring non-Google styled file %s" % file
       else:
-        cpplint.ProcessFile(file, 0)
+        cpplint.ProcessFile(file, cpplint._cpplint_state.verbose_level)
+
+  print "Total errors found: %d\n" % cpplint._cpplint_state.error_count
 
 
 def Changes():
   """Print all the changlists and their files."""
   for cl in GetCLs():
     change_info = LoadChangelistInfo(cl, True, True)
     print "\n--- Changelist " + change_info.name + ":"
     for file in change_info.files:
       print "".join(file)
 
@@ skipping 48 matching lines @@
   # change didn't exist. All other commands require an existing change.
   fail_on_not_found = command != "try" and command != "change"
   if command == "try" and changename.find(',') != -1:
     change_info = LoadChangelistInfoForMultiple(changename, True, True)
   else:
     change_info = LoadChangelistInfo(changename, fail_on_not_found, True)
 
   if command == "change":
     Change(change_info)
   elif command == "lint":
-    Lint(change_info)
+    Lint(change_info, argv[3:])
   elif command == "upload":
     UploadCL(change_info, argv[3:])
   elif command == "commit":
     Commit(change_info, argv[3:])
   elif command == "delete":
     change_info.Delete()
   elif command == "try":
     # When the change contains no file, send the "changename" positional
     # argument to trychange.py.
     if change_info.files:
       args = argv[3:]
     else:
       change_info = None
       args = argv[2:]
     TryChange(change_info, args)
   else:
     # Everything else that is passed into gcl we redirect to svn, after adding
     # the files. This allows commands such as 'gcl diff xxx' to work.
     args =["svn", command]
     root = GetRepositoryRoot()
     args.extend([os.path.join(root, x) for x in change_info.FileList()])
     RunShell(args, True)
   return 0
 
 
 if __name__ == "__main__":
   sys.exit(main())