Issue 18138: Allows cpplints arguments to be used within gcl....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18138: Allows cpplints arguments to be used within gcl.... (Closed)

Created:
11 years, 11 months ago by Mohamed Mansour (USE mhm)

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/depot_tools/

Visibility:
Public.

Description

Allows cpplints arguments to be used within gcl. Plus, fixes some errors when files cannot be linted This is needed to allow us change directory to this file instead of recieving "Cannot read file" all the time. os.chdir(GetRepositoryRoot()) Added a stats thing at the end, to see how many lint errors happened.

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -35 lines)			Patch
M	development/release/linux/gcl.py	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	development/release/mac/gcl.py	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	development/release/win/gcl.py	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	release/linux/gcl.py	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	release/mac/gcl.py	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	release/win/gcl.py	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	src/release/gcl.py	View	2 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mohamed Mansour (USE mhm)

This took me over an hour to just make scons work :( gcl change was ...

11 years, 11 months ago (2009-01-16 02:02:23 UTC) #1

Mohamed Mansour (USE mhm)

11 years, 11 months ago (2009-01-21 00:55:25 UTC) #3

On 2009/01/16 20:26:45, John Abd-El-Malek wrote:
> lgtm

Who is going to commit it :)

Expand Messages | Collapse Messages