Move the grid-area shorthand into CSSPropertyParser

Move the grid-area shorthand into CSSPropertyParser

Move the grid-area shorthand from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
Committed: https://crrev.com/6af7ef0418bea43e80ff4cd05ea70d7f12d369b2
Cr-Commit-Position: refs/heads/master@{#382244}

[rwlbuis, 2016-03-18 16:53:28]

Patchset #2 (id:20001) has been deleted

[rwlbuis, 2016-03-20 19:53:52]

Description was changed from

==========
grid-area WIP


grid-col WIP

BUG=
==========

to

==========
Move the grid-area shorthands into CSSPropertyParser

Move the grid-area-column/grid-area-row shorthands from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2016-03-20 19:55:00]

Description was changed from

==========
Move the grid-area shorthands into CSSPropertyParser

Move the grid-area-column/grid-area-row shorthands from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

to

==========
Move the grid-area shorthands into CSSPropertyParser

Move the grid-area shorthands from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2016-03-20 19:55:28]

Description was changed from

==========
Move the grid-area shorthands into CSSPropertyParser

Move the grid-area shorthands from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

to

==========
Move the grid-area shorthand into CSSPropertyParser

Move the grid-area shorthand from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2016-03-20 19:55:47]

Description was changed from

==========
Move the grid-area shorthand into CSSPropertyParser

Move the grid-area shorthand from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

to

==========
Move the grid-area shorthand into CSSPropertyParser

Move the grid-area shorthand from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2016-03-20 19:56:09]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-03-20 19:56:10]

PTAL.

[Timothy Loh, 2016-03-21 00:01:48]

On 2016/03/20 19:56:10, rwlbuis wrote:
> PTAL.

lgtm

[Timothy Loh, 2016-03-21 00:14:30]

err forgot to publish comments :)

https://codereview.chromium.org/1813763003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1813763003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:4220:
ASSERT_UNUSED(shorthand, shorthand.length() == 4);
or just ASSERT(gridAreaShorthand().length() == 4)?

[rwlbuis, 2016-03-21 00:26:45]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-03-21 00:26:46]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1813763003/#ps60001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-03-21 00:26:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1813763003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1813763003/60001

[commit-bot: I haz the power, 2016-03-21 02:12:55]

Description was changed from

==========
Move the grid-area shorthand into CSSPropertyParser

Move the grid-area shorthand from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

to

==========
Move the grid-area shorthand into CSSPropertyParser

Move the grid-area shorthand from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

[commit-bot: I haz the power, 2016-03-21 02:12:56]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-21 02:14:36]

Description was changed from

==========
Move the grid-area shorthand into CSSPropertyParser

Move the grid-area shorthand from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

to

==========
Move the grid-area shorthand into CSSPropertyParser

Move the grid-area shorthand from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780

Committed: https://crrev.com/6af7ef0418bea43e80ff4cd05ea70d7f12d369b2
Cr-Commit-Position: refs/heads/master@{#382244}
==========

[commit-bot: I haz the power, 2016-03-21 02:14:38]

Patchset 3 (id:??) landed as
https://crrev.com/6af7ef0418bea43e80ff4cd05ea70d7f12d369b2
Cr-Commit-Position: refs/heads/master@{#382244}