tools/android/loading/test_utils.py - Issue 1813723002: clovis: Identify prefetchable resources from dependencies and tracing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/loading/test_utils.py

Issue 1813723002: clovis: Identify prefetchable resources from dependencies and tracing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/loading/test_utils.py

diff --git a/tools/android/loading/test_utils.py b/tools/android/loading/test_utils.py

index f1c80c28291a8c2f95e7bc956d39d2847bbe807d..38737c0ceb0a31fcdde4b8ab6b50d6b4096532ab 100644

--- a/tools/android/loading/test_utils.py

+++ b/tools/android/loading/test_utils.py

@@ -125,7 +125,7 @@ def LoadingTraceFromEvents(requests, page_events=None, trace_events=None):

"""Returns a LoadingTrace instance from a list of requests and page events."""

request = FakeRequestTrack(requests)

page_event_track = FakePageTrack(page_events if page_events else [])

- if trace_events:

+ if trace_events is not None:

tracing_track = tracing.TracingTrack(None)

tracing_track.Handle('Tracing.dataCollected',

{'params': {'value': [e for e in trace_events]}})

« tools/android/loading/prefetch_view.py ('K') | « tools/android/loading/request_dependencies_lens_unittest.py ('k') | tools/android/loading/tracing.py » ('j') | no next file with comments »