Issue 18137007: DevTools: add about:flag for ADB-less remote debugging.

Issue 18137007: DevTools: add about:flag for ADB-less remote debugging. (Closed)

Created:
7 years, 5 months ago by pfeldman

Modified:
7 years, 5 months ago

Reviewers:
vsevik

CC:
chromium-reviews, aandrey+blink_chromium.org, paulirish+reviews_chromium.org, vsevik, yurys

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: add about:flag for ADB-less remote debugging. BUG=258017 R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211367

Patch Set 2 : For landing #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+289 lines, -125 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/adb/android_rsa.h	View		2 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/devtools/adb/android_rsa.cc	View		4 chunks	+9 lines, -13 lines	0 comments	Download
M	chrome/browser/devtools/adb/android_usb_device.h	View		4 chunks	+12 lines, -6 lines	0 comments	Download
M	chrome/browser/devtools/adb/android_usb_device.cc	View	1	10 chunks	+73 lines, -27 lines	0 comments	Download
M	chrome/browser/devtools/devtools_adb_bridge.h	View	1	5 chunks	+57 lines, -4 lines	0 comments	Download
M	chrome/browser/devtools/devtools_adb_bridge.cc	View	1	12 chunks	+103 lines, -64 lines	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://chromiumcodereview.appspot.com/18137007/diff/1/chrome/browser/devtools/adb/android_usb_device.cc File chrome/browser/devtools/adb/android_usb_device.cc (right): https://chromiumcodereview.appspot.com/18137007/diff/1/chrome/browser/devtools/adb/android_usb_device.cc#newcode215 chrome/browser/devtools/adb/android_usb_device.cc:215: std::vector<scoped_refptr<UsbDevice> > usb_devices; UsbDevices https://chromiumcodereview.appspot.com/18137007/diff/1/chrome/browser/devtools/devtools_adb_bridge.cc File chrome/browser/devtools/devtools_adb_bridge.cc (right): ...

7 years, 5 months ago (2013-07-11 15:59:54 UTC) #2

pfeldman

https://codereview.chromium.org/18137007/diff/1/chrome/browser/devtools/adb/android_usb_device.cc File chrome/browser/devtools/adb/android_usb_device.cc (right): https://codereview.chromium.org/18137007/diff/1/chrome/browser/devtools/adb/android_usb_device.cc#newcode215 chrome/browser/devtools/adb/android_usb_device.cc:215: std::vector<scoped_refptr<UsbDevice> > usb_devices; On 2013/07/11 15:59:54, vsevik wrote: > ...

7 years, 5 months ago (2013-07-11 16:26:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/18137007/39001

7 years, 5 months ago (2013-07-11 18:12:12 UTC) #4

pfeldman

7 years, 5 months ago (2013-07-12 08:56:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r211367 (presubmit successful).

Expand Messages | Collapse Messages