Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2551)

Unified Diff: chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h

Issue 1813693003: Fixed a fullscreen race condition on OSX (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h
diff --git a/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h b/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h
index 332bd949267b62259868147efeac6f2a7b4727af..55447eca48ada6376b72cbbbe28f7be7b1eb7199 100644
--- a/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h
+++ b/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h
@@ -9,6 +9,13 @@
@class FramedBrowserWindow;
+@protocol BrowserWindowFullscreenTransitionDelegate
Robert Sesek 2016/03/18 16:41:13 Does this class always operate on a BrowserWindowC
+
+// Called after the exit fullscreen animation is completed.
+- (void)finishedExitingFullscreen;
+
+@end
+
// This class is responsible for managing the custom transition of a
// BrowserWindow from its normal state into an AppKit Fullscreen state
// and vice versa.
@@ -101,13 +108,18 @@
// enters fullscreen. initExitWithWindow will create one that exits fullscreen,
// using |frame| as the frame that |window| is going to transition into.
- (instancetype)initEnterWithWindow:(FramedBrowserWindow*)window;
-- (instancetype)initExitWithWindow:(FramedBrowserWindow*)window
- frame:(NSRect)frame
- tabStripBackgroundView:(NSView*)view;
+- (instancetype)
+ initExitWithWindow:(FramedBrowserWindow*)window
+ delegate:(id<BrowserWindowFullscreenTransitionDelegate>)delegate
+ frame:(NSRect)frame
+tabStripBackgroundView:(NSView*)view;
// Returns the windows to be used in the custom fullscreen transition.
- (NSArray*)customWindowsForFullScreenTransition;
+// Returns true if the fullscreen transition is completed.
+- (BOOL)isTransitionCompleted;
+
// This method begins animation for exit or enter fullscreen transition.
// In this method, the following happens:
// - Animates the snapshot to the expected final size of the window while

Powered by Google App Engine
This is Rietveld 408576698