Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1813673002: Add guard for crash in MemoryCache::pruneDeadResources (Closed)

Created:
4 years, 9 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 9 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add guard for crash in MemoryCache::pruneDeadResources Although the root cause of crash is not clear now, maybe we'd better add guard firstly to avoid crash. BUG=594644 Committed: https://crrev.com/2ab370811b8850b96c579df7b545b901302b68df Cr-Commit-Position: refs/heads/master@{#381761}

Patch Set 1 #

Patch Set 2 : Add TODO note #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
leonhsl(Using Gerrit)
Hi Mike, Would you PTAL? I've already uploaded another CL trying to solve this crash ...
4 years, 9 months ago (2016-03-17 06:18:15 UTC) #2
Mike West
LGTM, but please add a TODO noting that we shouldn't be hitting this case, and ...
4 years, 9 months ago (2016-03-17 16:20:11 UTC) #3
leonhsl(Using Gerrit)
On 2016/03/17 16:20:11, Mike West wrote: > LGTM, but please add a TODO noting that ...
4 years, 9 months ago (2016-03-17 16:50:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813673002/20001
4 years, 9 months ago (2016-03-17 16:51:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 18:46:18 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 18:48:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ab370811b8850b96c579df7b545b901302b68df
Cr-Commit-Position: refs/heads/master@{#381761}

Powered by Google App Engine
This is Rietveld 408576698