Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1813663002: Don't collapse whitespace in contenteditable=plaintext-only. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't collapse whitespace in contenteditable=plaintext-only. Rewrite white-space property for contenteditable=plaintext-only elements as: normal -> pre-wrap nowrap -> pre pre-line -> pre-wrap because whitespace collapsing doesn't make sense in plain-text editing. The new behavior matches to Microsoft Edge for TEXTAREA. BUG=595491 Committed: https://crrev.com/73a59b847f8b048bf26d7806bafa403c8f3f95d6 Cr-Commit-Position: refs/heads/master@{#381668}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/is-richly-editable-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/input/textarea-white-space-normal-trailing-space.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/input/textarea-white-space-normal-trailing-space-expected.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/stale-grid-layout-2-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/8145-1-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/8145-1-expected.txt View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/textarea/basic-textareas-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/textarea/basic-textareas-expected.txt View 4 chunks +18 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
tkent
yosin@, would you review this please?
4 years, 9 months ago (2016-03-17 05:59:03 UTC) #4
yosin_UTC9
lgtm
4 years, 9 months ago (2016-03-17 06:51:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813663002/20001
4 years, 9 months ago (2016-03-17 06:51:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-17 07:49:21 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 07:51:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73a59b847f8b048bf26d7806bafa403c8f3f95d6
Cr-Commit-Position: refs/heads/master@{#381668}

Powered by Google App Engine
This is Rietveld 408576698