Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1813643002: [MD settings] icon color and sizing centralized (Closed)

Created:
4 years, 9 months ago by dschuyler
Modified:
4 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dcheng, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] icon color and sizing centralized This CL moves the common iron-icon coloring and sizing to the settings shared style-module. The variations and one-offs are now in more specific files (such as the side nav icons). BUG=589630 Committed: https://crrev.com/87253c9c37f4f01f68041ba88a015c94f1934ddb Cr-Commit-Position: refs/heads/master@{#381772}

Patch Set 1 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -41 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.css View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_dropdown_menu.html View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.css View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/user_list.css View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 4 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dschuyler
Screen shots at http://imgur.com/a/EXRaK
4 years, 9 months ago (2016-03-17 18:32:03 UTC) #3
dpapad
lgtm
4 years, 9 months ago (2016-03-17 18:57:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813643002/20001
4 years, 9 months ago (2016-03-17 19:11:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-17 19:25:27 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 19:27:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87253c9c37f4f01f68041ba88a015c94f1934ddb
Cr-Commit-Position: refs/heads/master@{#381772}

Powered by Google App Engine
This is Rietveld 408576698