Issue 1813633002: Fix pdf_use_skia=1 on mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1813633002: Fix pdf_use_skia=1 on mac. (Closed)

Created:
4 years, 9 months ago by dsinclair

Modified:
4 years, 9 months ago

Reviewers:
Tom Sepez, _cary

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	skia/ext/google_logging.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

dsinclair

PTAL. With this change I can build pdfium_use_skia and generate skp files on my Mac.

4 years, 9 months ago (2016-03-17 01:28:39 UTC) #2

dsinclair

4 years, 9 months ago (2016-03-17 17:27:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
900323a8857ce0d9f6a57e535cd864b0f649bb9c (presubmit successful).