chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc - Issue 181363002: Properly handle failure modes in the wildcard login check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc

Issue 181363002: Properly handle failure modes in the wildcard login check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/login_performer.cc ('K') | « chrome/browser/chromeos/login/login_performer.cc ('k') | chrome/browser/chromeos/policy/wildcard_login_checker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc

diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc

index 83d59545396f126164f9e5d08e9a08ba01f1466d..9437367b4cab2d29675e87e126925ba9ca8e41a9 100644

--- a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc

+++ b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc

@@ -49,8 +49,9 @@ const char kUMAInitialFetchOAuth2Error[] =

const char kUMAInitialFetchOAuth2NetworkError[] =

"Enterprise.UserPolicyChromeOS.InitialFetch.OAuth2NetworkError";

-void OnWildcardCheckCompleted(const std::string& username, bool result) {

- if (!result) {

+void OnWildcardCheckCompleted(const std::string& username,

+ WildcardLoginChecker::Result result) {

+ if (result == WildcardLoginChecker::RESULT_BLOCKED) {

LOG(ERROR) << "Online wildcard login check failed, terminating session.";

// TODO(mnissler): This only removes the user pod from the login screen, but