Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 1813603003: Remove nullchecks for the provider's context. (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, danakj+watch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jam, jbroman, krit, blink-reviews, Rik, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, f(malita), kinuko+watch, Stephen Chennney, rwlbuis, dcheng, piman, no sievers, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove nullchecks for the provider's context. If the provider is not null, it will have a context that is not null. The provider is a WebGraphicsContext3DProviderImpl, which is given a ContextProviderWebContext. The ContextProviderWebContext is a ContextProviderCommandBuffer, the factory for which returns a null provider if the underlying context is null. Further, the provider comes from RenderThreadImpl's SharedMainThreadContextProvider(), which will return null if the provider is null, or if the provider fails to initialize its GL context. R=junov@chromium.org, kbr@chromium.org BUG=584497 Committed: https://crrev.com/0b5fbe3c7b257fde5861ad986ec77b2c9f6c23c1 Cr-Commit-Position: refs/heads/master@{#381765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/renderer/webgraphicscontext3d_provider_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
danakj
Some citations: https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/render_thread_impl.cc&rcl=1458156883&l=1553 creates the shared ContextProvider. https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/renderer_blink_platform_impl.cc&rcl=1458156883&l=1048 constructs the WebGC3DProviderImpl, and gives it the ...
4 years, 9 months ago (2016-03-17 01:05:40 UTC) #1
danakj
+piman for content/
4 years, 9 months ago (2016-03-17 01:05:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813603003/1
4 years, 9 months ago (2016-03-17 01:06:13 UTC) #5
piman
lgtm
4 years, 9 months ago (2016-03-17 01:32:42 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813603003/1
4 years, 9 months ago (2016-03-17 18:43:07 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 18:48:50 UTC) #11
Justin Novosad
On 2016/03/17 18:43:07, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 9 months ago (2016-03-17 18:52:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813603003/1
4 years, 9 months ago (2016-03-17 18:53:27 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 19:02:51 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 19:04:01 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b5fbe3c7b257fde5861ad986ec77b2c9f6c23c1
Cr-Commit-Position: refs/heads/master@{#381765}

Powered by Google App Engine
This is Rietveld 408576698