Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1813583002: Convert radio-group-keyboard-change-event.html to a testharness.js test. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert radio-group-keyboard-change-event.html to a testharness.js test. It was a dumpAsText() test without js-test.js. This CL has no behavior changes. Committed: https://crrev.com/79a6ade947f495b510efc6280ba91e58b37c3e26 Cr-Commit-Position: refs/heads/master@{#381663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -113 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html View 4 chunks +57 lines, -80 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
keishi, would you review this please?
4 years, 9 months ago (2016-03-17 03:32:52 UTC) #2
keishi
LGTM
4 years, 9 months ago (2016-03-17 05:14:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813583002/1
4 years, 9 months ago (2016-03-17 05:34:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 05:41:56 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 05:43:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79a6ade947f495b510efc6280ba91e58b37c3e26
Cr-Commit-Position: refs/heads/master@{#381663}

Powered by Google App Engine
This is Rietveld 408576698