Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1813553005: switch patheffects over to sk_sp (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : try to fix xpsdevice #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -256 lines) Patch
M bench/DashBench.cpp View 1 11 chunks +11 lines, -14 lines 0 comments Download
M gm/arcto.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/bug530095.cpp View 1 3 chunks +6 lines, -7 lines 0 comments Download
M gm/dashcircle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/dashcubics.cpp View 1 1 chunk +16 lines, -18 lines 0 comments Download
M gm/dashing.cpp View 1 6 chunks +6 lines, -7 lines 0 comments Download
M gm/pathcontourstart.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M gm/patheffects.cpp View 1 4 chunks +11 lines, -13 lines 0 comments Download
M gm/strokes.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/stroketext.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/textbloblooper.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M gm/texteffects.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +6 lines, -1 line 0 comments Download
M include/core/SkPathEffect.h View 1 2 3 6 chunks +30 lines, -15 lines 0 comments Download
M include/effects/Sk1DPathEffect.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M include/effects/Sk2DPathEffect.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M include/effects/SkArcToPathEffect.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkCornerPathEffect.h View 1 1 chunk +9 lines, -1 line 0 comments Download
M include/effects/SkDashPathEffect.h View 1 chunk +7 lines, -1 line 0 comments Download
M include/effects/SkDiscretePathEffect.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M samplecode/ClockFaceView.cpp View 1 3 chunks +5 lines, -6 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 7 chunks +9 lines, -12 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 chunks +15 lines, -19 lines 0 comments Download
M samplecode/SamplePath.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SamplePathEffects.cpp View 1 3 chunks +16 lines, -21 lines 0 comments Download
M samplecode/SampleSlides.cpp View 1 9 chunks +17 lines, -19 lines 0 comments Download
M src/animator/SkDrawPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPaint.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M src/core/SkPathEffect.cpp View 1 4 chunks +13 lines, -33 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/effects/Sk2DPathEffect.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkArcToPathEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkCornerPathEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkDiscretePathEffect.cpp View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/xps/SkXPSDevice.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tests/AsADashTest.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/DashPathEffectTest.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/DrawPathTest.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M tests/PictureTest.cpp View 1 3 chunks +3 lines, -5 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
reed1
incomplete, but wanted to sync up on the direction
4 years, 9 months ago (2016-03-18 14:05:59 UTC) #3
caryclark
lgtm
4 years, 9 months ago (2016-03-18 14:26:07 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813553005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813553005/60001
4 years, 9 months ago (2016-03-18 16:14:37 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/7185)
4 years, 9 months ago (2016-03-18 16:19:11 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813553005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813553005/80001
4 years, 9 months ago (2016-03-18 16:23:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813553005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813553005/80001
4 years, 9 months ago (2016-03-18 16:58:58 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/9fbee18f691a0afed1e38a851048ce06063505ed
4 years, 9 months ago (2016-03-18 17:00:37 UTC) #16
reed1
4 years, 9 months ago (2016-03-18 17:17:00 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1817543002/ by reed@google.com.

The reason for reverting is: some build breaks, possibly related to paint having
to know what a patheffect is.

Powered by Google App Engine
This is Rietveld 408576698