Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: net/quic/quic_connection_test.cc

Issue 1813513002: Deprecate quic_respect_send_alarm2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116877752
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index 7b8314a18d3bb42f6621628a464a5f3c651dbc2e..4f5698f7052ba5a61a9c6738c2db158f26f82f4c 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -1315,10 +1315,6 @@ TEST_P(QuicConnectionTest, AckReceiptCausesAckSendBadEntropy) {
ProcessPacket(kDefaultPathId, 1);
// Delay sending, then queue up an ack.
- if (!FLAGS_quic_respect_send_alarm2) {
- EXPECT_CALL(*send_algorithm_, TimeUntilSend(_, _, _))
- .WillOnce(testing::Return(QuicTime::Delta::FromMicroseconds(1)));
- }
QuicConnectionPeer::SendAck(&connection_);
// Process an ack with a least unacked of the received ack.
@@ -4572,7 +4568,6 @@ TEST_P(QuicConnectionTest, DoNotSendGoAwayTwice) {
}
TEST_P(QuicConnectionTest, ReevaluateTimeUntilSendOnAck) {
- ValueRestore<bool> old_flag(&FLAGS_quic_respect_send_alarm2, true);
EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
connection_.SendStreamDataWithString(kClientDataStreamId1, "foo", 0, !kFin,
nullptr);
@@ -4601,7 +4596,6 @@ TEST_P(QuicConnectionTest, ReevaluateTimeUntilSendOnAck) {
}
TEST_P(QuicConnectionTest, SendAcksImmediately) {
- FLAGS_quic_respect_send_alarm2 = true;
CongestionBlockWrites();
SendAckPacketToPeer();
}
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698