Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: net/quic/congestion_control/tcp_cubic_sender_base.cc

Issue 1813513002: Deprecate quic_respect_send_alarm2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116877752
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/congestion_control/tcp_cubic_sender_packets.h" 5 #include "net/quic/congestion_control/tcp_cubic_sender_packets.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "net/quic/congestion_control/prr_sender.h" 10 #include "net/quic/congestion_control/prr_sender.h"
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 largest_sent_packet_number_ = packet_number; 171 largest_sent_packet_number_ = packet_number;
172 hybrid_slow_start_.OnPacketSent(packet_number); 172 hybrid_slow_start_.OnPacketSent(packet_number);
173 return true; 173 return true;
174 } 174 }
175 175
176 QuicTime::Delta TcpCubicSenderBase::TimeUntilSend( 176 QuicTime::Delta TcpCubicSenderBase::TimeUntilSend(
177 QuicTime /* now */, 177 QuicTime /* now */,
178 QuicByteCount bytes_in_flight, 178 QuicByteCount bytes_in_flight,
179 HasRetransmittableData has_retransmittable_data) const { 179 HasRetransmittableData has_retransmittable_data) const {
180 if (has_retransmittable_data == NO_RETRANSMITTABLE_DATA) { 180 if (has_retransmittable_data == NO_RETRANSMITTABLE_DATA) {
181 DCHECK(!FLAGS_quic_respect_send_alarm2); 181 QUIC_BUG << "TimeUntilSend's has_retransmittable_data argument deprecated.";
182 // For TCP we can always send an ACK immediately. 182 // For TCP we can always send an ACK immediately.
183 return QuicTime::Delta::Zero(); 183 return QuicTime::Delta::Zero();
184 } 184 }
185 if (InRecovery()) { 185 if (InRecovery()) {
186 // PRR is used when in recovery. 186 // PRR is used when in recovery.
187 return prr_.TimeUntilSend(GetCongestionWindow(), bytes_in_flight, 187 return prr_.TimeUntilSend(GetCongestionWindow(), bytes_in_flight,
188 GetSlowStartThreshold()); 188 GetSlowStartThreshold());
189 } 189 }
190 if (GetCongestionWindow() > bytes_in_flight) { 190 if (GetCongestionWindow() > bytes_in_flight) {
191 return QuicTime::Delta::Zero(); 191 return QuicTime::Delta::Zero();
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 void TcpCubicSenderBase::OnConnectionMigration() { 258 void TcpCubicSenderBase::OnConnectionMigration() {
259 hybrid_slow_start_.Restart(); 259 hybrid_slow_start_.Restart();
260 prr_ = PrrSender(); 260 prr_ = PrrSender();
261 largest_sent_packet_number_ = 0; 261 largest_sent_packet_number_ = 0;
262 largest_acked_packet_number_ = 0; 262 largest_acked_packet_number_ = 0;
263 largest_sent_at_last_cutback_ = 0; 263 largest_sent_at_last_cutback_ = 0;
264 last_cutback_exited_slowstart_ = false; 264 last_cutback_exited_slowstart_ = false;
265 } 265 }
266 266
267 } // namespace net 267 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698